Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): fix memory leaks in complex data structures and support generic tuple #4468

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

liulx20
Copy link
Collaborator

@liulx20 liulx20 commented Feb 7, 2025

Fixes

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.78%. Comparing base (383a1e0) to head (06202cc).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4468   +/-   ##
=======================================
  Coverage   58.78%   58.78%           
=======================================
  Files          12       12           
  Lines         592      592           
=======================================
  Hits          348      348           
  Misses        244      244           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 383a1e0...06202cc. Read the comment docs.

Copy link
Contributor

github-actions bot commented Feb 8, 2025

Please check the preview of the documentation changes at
https://f92f84ce.graphscope-docs-preview.pages.dev

@liulx20 liulx20 changed the title fix(interactive): fix memory leaks in complex data structures fix(interactive): fix memory leaks in complex data structures and support generic tuple Feb 8, 2025
},
[&status](const gs::Status& err) {
[&status, &ctx](const gs::Status& err) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the capture&ctx safe? Since ctx has already been applied with std::move in .Execute.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok here, as described in this. The object being moved is put into a 'valid but unspecified state.' This means that after an object is moved from, it can still be accessed safely, but you should not make any assumptions about its value or state. In this case, we are not accessing the content of context when an error occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants