Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(interactive): Add Error Codes in CompilePlan JNI Results #4472

Merged
merged 13 commits into from
Feb 10, 2025

Conversation

shirly121
Copy link
Collaborator

What do these changes do?

as titled.

Related issue number

Fixes

@shirly121 shirly121 changed the title refactor(interactive): Add Error Codes in JNI Results refactor(interactive): Add Error Codes in CompilePlan JNI Results Feb 8, 2025
Copy link
Contributor

github-actions bot commented Feb 8, 2025

Please check the preview of the documentation changes at
https://8347a8c7.graphscope-docs-preview.pages.dev

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.10%. Comparing base (04ebffa) to head (fccd54b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4472      +/-   ##
==========================================
- Coverage   35.72%   33.10%   -2.63%     
==========================================
  Files         126      126              
  Lines       13264    13264              
==========================================
- Hits         4739     4391     -348     
- Misses       8525     8873     +348     

see 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04ebffa...fccd54b. Read the comment docs.

Copy link
Collaborator

@zhanglei1949 zhanglei1949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirly121 shirly121 merged commit 10ed3b3 into alibaba:main Feb 10, 2025
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants