Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade git-commit-id-plugin from 4.9.9 to 4.0.5 #3001

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hboutemy
Copy link
Contributor

@hboutemy hboutemy commented Mar 22, 2025

4.0.1 was working perfectly before
but since Arthas 3.7.3, where releases are done with full profile, rebuild from Reproducible Builds cannot generate arthas-git.properties with plugin 4.9.9, but it would still work with 4.0.1 (tested locally)
see https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/com/taobao/arthas/README.md

upgrade from 4.0.1 to 4.9.9 was done without explanation 2b1d4d0 , probably for common sense "newer is better"

@hboutemy hboutemy changed the title upgrade git-commit-id-plugin from 4.9.9 to 4.9.10 downgrade git-commit-id-plugin from 4.9.9 to 4.0.1 Mar 22, 2025
@hboutemy
Copy link
Contributor Author

hboutemy commented Mar 22, 2025

testing build with plugin 4.0.1 and JDK 17 fails: Error: Failed to execute goal pl.project13.maven:git-commit-id-plugin:4.0.1:revision (default) on project math-game: Could not complete Mojo execution...: Unable to make private void java.util.Properties.store0(java.io.BufferedWriter,java.lang.String,boolean) throws java.io.IOException accessible: module java.base does not "opens java.util" to unnamed module @7b80af04 -> [Help 1]

need to use 4.0.5 instead: benefit from fix in 4.0.4 https://github.com/git-commit-id/git-commit-id-maven-plugin/releases/tag/v4.0.4

@hboutemy hboutemy changed the title downgrade git-commit-id-plugin from 4.9.9 to 4.0.1 downgrade git-commit-id-plugin from 4.9.9 to 4.0.5 Mar 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant