feat: rsc to ssr #6682
Open
feat: rsc to ssr #6682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feat-rsc #6682 +/- ##
============================================
- Coverage 77.93% 77.58% -0.36%
============================================
Files 223 225 +2
Lines 19668 19782 +114
Branches 2461 2466 +5
============================================
+ Hits 15329 15348 +19
- Misses 4307 4402 +95
Partials 32 32 ☔ View full report in Codecov by Sentry. |
chenjun1011
commented
Dec 20, 2023
| @@ -112,7 +117,7 @@ const transformPipe = (options: PluginOptions = {}): Plugin => { | |||
| let sourceMap = null; | |||
|
|
|||
| if (plugin.load && (!loadInclude || loadInclude?.(id))) { | |||
| const result = await plugin.load.call(pluginContext, id); | |||
| const result = await plugin.load.call(pluginContext, id, args.namespace); | |||
There was a problem hiding this comment.
希望在插件的 load 中只处理 resolved 的 path，所以透传了 namespace 进行标记，看看是否有更好的方式。
ClarkXia
force-pushed
the
feat-rsc-to-ssr
branch
from
fd7993b
to
f514221
Compare
ClarkXia
force-pushed
the
feat-rsc-to-ssr
branch
from
f514221
to
fd7993b
Compare
ClarkXia
force-pushed
the
feat-rsc-to-ssr
branch
from
fd7993b
to
e85d65f
Compare
luhc228
reviewed
Dec 27, 2023
Comment on lines
+30
to
+34
| await new Promise<any>((resolve) => { | ||
| setTimeout(() => resolve(null), 3000); | ||
| }); | ||
|
|
||
| return fakeData; |
| render() { | ||
| if (this.state.hasError) { | ||
| // @ts-ignore | ||
| const ClientComments = lazy(() => import('./CommentsWithServerError')); |
There was a problem hiding this comment.
ClientComments -> CommentsWithServerError
|
|
||
| const CSSRegex = /\.(css|sass|scss)$/; | ||
|
|
||
| Object.keys(ssrManifest).map(router => { |
| if (modules[id] || CSSRegex.test(id)) return; | ||
| modules[id] = true; | ||
| index++; | ||
| imports.push(`import * as component_${index} from "(rsc)${id}";`); |
There was a problem hiding this comment.
(rsc) 感觉可以换成 rsc:，然后注释下后面会替换掉
| name: 'esbuild-rsc-loader', | ||
| setup(build: PluginBuild) { | ||
| build.onResolve({ filter: /react-ssr-module-mapping.json$/ }, (args) => { | ||
| if (args.path === 'virtual-rsc-module:react-ssr-module-mapping.json') { |
There was a problem hiding this comment.
这个是 Server 端渲染 RSC 结果到 SSR 时，需要用到 Client Components 的 mapping。会根据这份产物加载对应的 Client Component 的 Server 端 Bundle，然后渲染
| plugins: [ | ||
| serverComponent && transformRSCDirectivePlugin(), |
There was a problem hiding this comment.
插件命名上，建议是 RemoveUseClientDirectivePlugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
实现思路