feat: support host monitor #1890

Abingcbc · 2024-11-18T02:08:43Z

打通进程元信息采集链路

TODO：

支持更多字段
可观测指标

core/common/timer/HostMonitorTimerEvent.cpp

messixukejia · 2024-11-19T01:15:11Z

core/models/PipelineEventGroup.h

@@ -58,6 +58,8 @@ enum class EventGroupMetaKey {
    PROMETHEUS_SCRAPE_TIMESTAMP_MILLISEC,
    PROMETHEUS_UP_STATE,

+    HOST_MONITOR_COLLECT_TIME,


这个字段是否不可以跟具体业务无关，作为通用字段。

messixukejia · 2024-11-25T06:47:05Z

core/runner/sink/http/HttpSink.cpp

                    LOG_DEBUG(
                        sLogger,
                        ("send http request succeeded, item address", request->mItem)(
                            "config-flusher-dst", QueueKeyManager::GetInstance()->GetName(request->mItem->mQueueKey))(
                            "response time", ToString(responseTimeMs) + "ms")("try cnt", ToString(request->mTryCnt))(
                            "sending cnt", ToString(FlusherRunner::GetInstance()->GetSendingBufferCount())));
+                    static_cast<HttpFlusher*>(request->mItem->mFlusher)->OnSendDone(request->mResponse, request->mItem);


这个文件改动原因是什么

这个debug日志会有core，遗留问题

messixukejia · 2024-11-25T07:00:06Z

core/host_monitor/collector/MockCollector.cpp

+ * limitations under the License.
+ */
+
+#include "MockCollector.h"


messixukejia · 2024-11-25T07:01:20Z

core/host_monitor/collector/CollectorManager.cpp

+
+namespace logtail {
+
+CollectorManager::CollectorManager() {


没太大必要删掉吧

messixukejia · 2024-11-25T07:20:08Z

core/plugin/processor/inner/ProcessorHostMetaNative.cpp

+const std::string ProcessorHostMetaNative::sName = "processor_host_meta_native";
+
+bool ProcessorHostMetaNative::Init(const Json::Value& config) {
+    auto hostType = ToString(getenv(DEFAULT_ENV_KEY_HOST_TYPE.c_str()));


这个机制也不合理。应该有个全局的管理中心，各业务方直接读值即可。这个事情日会上提下，讨论下。

messixukejia · 2024-11-25T07:23:41Z

core/constants/EntityConstants.cpp

+
+// for process entity
+const std::string DEFAULT_CONTENT_VALUE_ENTITY_TYPE_PROCESS = "process";
+const std::string DEFAULT_CONTENT_KEY_PROCESS_PID = "process_pid";


尽量与 TagConstants.cpp 中，日志、指标类型保持一致。

同时看看node-exporter的指标label做下参考。

node exporter的指标也是以下划线连接
node_固定前缀 + 指标类型 + 指标
e.g. node_memory_HugePages_Total

messixukejia · 2024-11-25T07:24:18Z

core/host_monitor/SystemInformationTools.cpp

+namespace logtail {
+
+int64_t GetSystemBootSeconds() {
+    static int64_t systemBootSeconds;


这个文件，是不是应该是collector的一部分？

这个是系统级的指标，会有多个collector用到。比如这个获取启动时间，cpu collector和process collector都要用到

messixukejia · 2024-11-25T07:31:25Z

core/plugin/processor/inner/ProcessorHostMetaNative.cpp

+    targetEvent->SetContent("binary", sourceEvent.GetContent(DEFAULT_CONTENT_KEY_PROCESS_BINARY));
+    targetEvent->SetContent("arguments", sourceEvent.GetContent(DEFAULT_CONTENT_KEY_PROCESS_ARGUMENTS));
+    targetEvent->SetContent("language", sourceEvent.GetContent(DEFAULT_CONTENT_KEY_PROCESS_LANGUAGE));
+    targetEvent->SetContent("containerID", sourceEvent.GetContent(DEFAULT_CONTENT_KEY_PROCESS_CONTAINER_ID));


DEFAULT_CONTENT_KEY_PROCESS_CONTAINER_ID没有set的地方？另外也不一定是container。

messixukejia · 2024-11-25T08:05:12Z

core/host_monitor/collector/ProcessCollector.cpp

+
+const size_t ProcessTopN = 20;
+
+void ProcessCollector::Collect(PipelineEventGroup& group) {


并发的必要性是什么？

core/common/FileSystemUtil.h

core/common/StringTools.cpp

core/common/timer/HostMonitorTimerEvent.cpp

henryzhx8 · 2024-11-26T07:42:16Z

core/plugin/input/InputHostMeta.h

+    std::string mDomain;
+    std::string mEntityType;
+    std::string mHostEntityID;


这三个成员有用吗？

henryzhx8 · 2024-11-26T08:06:30Z

core/plugin/input/InputHostMeta.h

+    bool Init(const Json::Value& config, Json::Value& optionalGoPipeline) override;
+    bool Start() override;
+    bool Stop(bool isPipelineRemoving) override;
+    bool SupportAck() const override { return false; }


先改成true

henryzhx8 · 2024-11-26T08:24:04Z

core/plugin/input/InputHostMeta.cpp

+
+bool InputHostMeta::Stop(bool isPipelineRemoving) {
+    LOG_INFO(sLogger, ("input host meta stop", mContext->GetConfigName()));
+    HostMonitorInputRunner::GetInstance()->RemoveCollector(mContext->GetConfigName());


如果pipelineremoving是false，不要调用

henryzhx8 · 2024-11-26T08:24:25Z

core/plugin/input/InputHostMeta.cpp

+bool InputHostMeta::Start() {
+    LOG_INFO(sLogger, ("input host meta start", mContext->GetConfigName()));
+    HostMonitorInputRunner::GetInstance()->Init();
+    HostMonitorInputRunner::GetInstance()->UpdateCollector(


函数里面判断有没有过这个config，决定是不是要加初始事件

henryzhx8 · 2024-11-26T08:43:54Z

core/host_monitor/HostMonitorInputRunner.cpp

+        if (ProcessQueueManager::GetInstance()->IsValidToPush(processQueueKey)) {
+            ProcessQueueManager::GetInstance()->PushQueue(processQueueKey, std::move(item));
+        } else {
+            std::this_thread::sleep_for(std::chrono::milliseconds(100));
+            // try again
+            if (ProcessQueueManager::GetInstance()->IsValidToPush(processQueueKey)) {
+                ProcessQueueManager::GetInstance()->PushQueue(processQueueKey, std::move(item));
+            } else {
+                LOG_WARNING(sLogger, ("process queue is full", "discard data")("config", configName));
+            }
+        }


用ProcessorRunner::GetInstance()->PushQueue

henryzhx8 · 2024-11-26T08:48:34Z

core/host_monitor/HostMonitorInputRunner.cpp

+    mThreadPool->Add([this, eventCopy]() mutable {
+        auto configName = eventCopy.GetConfigName();
+        auto collectorName = eventCopy.GetCollectorName();
+        auto processQueueKey = eventCopy.GetProcessQueueKey();
+        PipelineEventGroup group(std::make_shared<SourceBuffer>());
+        auto collector = CollectorManager::GetInstance()->GetCollector(collectorName);
+        collector->Collect(group);


感觉这边不太对，不应该有copy

henryzhx8 · 2024-11-26T08:50:09Z

core/host_monitor/HostMonitorInputRunner.cpp

+        LOG_DEBUG(sLogger, ("schedule host monitor collector again", configName)("collector", collectorName));
+
+        eventCopy.ResetForNextExec();
+        mTimer->PushEvent(std::make_unique<HostMonitorTimerEvent>(eventCopy));


这边直接构造新的

Abingcbc force-pushed the host_monitor branch 6 times, most recently from 6150e52 to bfdd9c2 Compare November 19, 2024 06:27

messixukejia requested changes Nov 25, 2024

View reviewed changes

henryzhx8 requested changes Nov 26, 2024

View reviewed changes

feat: support host monitor

3e12438

Abingcbc force-pushed the host_monitor branch from 4110e3d to 3e12438 Compare November 27, 2024 06:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support host monitor #1890

feat: support host monitor #1890

Abingcbc commented Nov 18, 2024

messixukejia Nov 19, 2024

messixukejia Nov 25, 2024

Abingcbc Nov 25, 2024

messixukejia Nov 25, 2024

messixukejia Nov 25, 2024

messixukejia Nov 25, 2024

messixukejia Nov 25, 2024

Abingcbc Nov 25, 2024

messixukejia Nov 25, 2024

Abingcbc Nov 25, 2024

messixukejia Nov 25, 2024

messixukejia Nov 25, 2024

henryzhx8 Nov 26, 2024

henryzhx8 Nov 26, 2024

henryzhx8 Nov 26, 2024

henryzhx8 Nov 26, 2024

henryzhx8 Nov 26, 2024

henryzhx8 Nov 26, 2024

henryzhx8 Nov 26, 2024


		const size_t ProcessTopN = 20;

		void ProcessCollector::Collect(PipelineEventGroup& group) {


		namespace logtail {

		CollectorManager::CollectorManager() {

feat: support host monitor #1890

Are you sure you want to change the base?

feat: support host monitor #1890

Conversation

Abingcbc commented Nov 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment