fix: dataSourceList 排序时直接点完成数据源会清空 #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YSMJ1994
suggested changes
Nov 23, 2023
| return context.sort.dataSourceList; | ||
| return context.sort.dataSourceList === context.dataSourceList | ||
| ? context.sort.dataSourceList | ||
| : context.dataSourceList; |
There was a problem hiding this comment.
这里的问题是不是 当没有发生排序时， context.sort.dataSourceList为空，所以导致了这个问题，那这里应该只是做一个 context.sort.dataSourceList 为空时的兜底逻辑。
你这段代码逻辑是：sort ds === ds 则使用 sort ds， 否则使用 ds。这样不就一直使用 ds了吗
There was a problem hiding this comment.
本意是给context.sort.dataSourceList 为空时兜底，当 SAVE_SORT 执行之后也会把 当前ds传给sort.ds,感觉效果是一样的，我改一下
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.