Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#11214): Optimization method com.alibaba.nacos.naming.core.v2.client.manager.impl.ConnectionBasedClientManager.clientConnected #11219

Closed
wants to merge 1 commit into from

Conversation

Bo-Qiu
Copy link
Contributor

@Bo-Qiu Bo-Qiu commented Oct 5, 2023

What is the purpose of the change

feat(#11214):
Optimization method com.alibaba.nacos.naming.core.v2.client.manager.impl.ConnectionBasedClientManager.clientConnected.
Before creating a client instance, first determine whether a client instance with the same clientId already exists in clientsMap. If it exists, no invalid client instance will be created.

…e.v2.client.manager.impl.ConnectionBasedClientManager.clientConnected
@codecov-commenter
Copy link

Codecov Report

Merging #11219 (d9b3587) into develop (f3fb428) will decrease coverage by 0.04%.
The diff coverage is 83.33%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #11219      +/-   ##
=============================================
- Coverage      54.12%   54.08%   -0.04%     
- Complexity      5580     5582       +2     
=============================================
  Files            907      907              
  Lines          28840    28846       +6     
  Branches        3190     3190              
=============================================
- Hits           15610    15602       -8     
- Misses         11886    11901      +15     
+ Partials        1344     1343       -1     
Files Coverage Δ
.../core/v2/client/manager/ClientManagerDelegate.java 81.81% <ø> (+3.55%) ⬆️
...ent/manager/impl/EphemeralIpPortClientManager.java 66.66% <100.00%> (+2.38%) ⬆️
...nt/manager/impl/PersistentIpPortClientManager.java 78.94% <100.00%> (+2.02%) ⬆️
...ent/manager/impl/ConnectionBasedClientManager.java 67.79% <66.66%> (-6.75%) ⬇️

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3fb428...d9b3587. Read the comment docs.

Copy link
Collaborator

@KomachiSion KomachiSion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

拒绝,多态方法用于方便扩展和复用使用设计,不给予删除

@KomachiSion KomachiSion closed this Oct 9, 2023
@Bo-Qiu Bo-Qiu deleted the feat/11214 branch November 24, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants