Fix 7 order-dependent tests by adding a precondition #3498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lxb007981
force-pushed
the
fix-od-flaky-r
branch
from
a08f6d4
to
f4f90b9
Compare
lxb007981
force-pushed
the
fix-od-flaky-r
branch
from
f4f90b9
to
771236b
Compare
|
@lxb007981 Can you open issue to explain pr purpose? |
Thank you for reviewing. This pr aims to fix the flakyness within this test class. The detailed issue is linked here. I'm willing to improve this pr is needed. |
This was referenced Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
This PR fix seven order-dependent tests by always adding a precondition.
Related test:
com.alibaba.cloud.nacos.configdata.NacosConfigDataLocationResolverTest.testResolveProfileSpecific_givenNothing_thenReturnDefaultProfile
com.alibaba.cloud.nacos.configdata.NacosConfigDataLocationResolverTest.testStartWithASlashIsOK
com.alibaba.cloud.nacos.configdata.NacosConfigDataLocationResolverTest.testDataIdMustBeSpecified
com.alibaba.cloud.nacos.configdata.NacosConfigDataLocationResolverTest.testInvalidDataId
com.alibaba.cloud.nacos.configdata.NacosConfigDataLocationResolverTest.whenCustomizeSuffix_thenOverrideDefault
com.alibaba.cloud.nacos.configdata.NacosConfigDataLocationResolverTest.testUrisInLocationShouldOverridesProperty
com.alibaba.cloud.nacos.configdata.NacosConfigDataLocationResolverTest.whenNoneInBootstrapContext_thenCreateNewConfigClientProperties
These seven tests are order-dependent flaky. they depend on the environment properties, but these properties are not properly set during the
setup(). Some other tests set the properties individually (liketestCommonPropertiesHasLowerPriority), which make the tests relying on these properties order-dependent.Does this pull request fix one issue?
#3503
Describe how you did it
Properties are now set in the
setup()method, which is executed before each test.Describe how to verify it
Using a test order randomizer can trigger this order-dependent flakiness. Or one can directly run one of the flaky tests individually (instead of run the whole test class), and it will throw some error.
Special notes for reviews