chore(ci): fix new spotbugs check errors since upgrade `spotbugs-ma…

…ven-plugin` 🐞
alibaba · Dec 6, 2023 · 83d8b4d · 83d8b4d
1 parent 9936cf2
commit 83d8b4d
Show file tree

Hide file tree

Showing 16 changed files with 30 additions and 0 deletions.
diff --git a/ttl-agent/src/main/java/com/alibaba/ttl3/agent/TtlAgent.java b/ttl-agent/src/main/java/com/alibaba/ttl3/agent/TtlAgent.java
@@ -8,6 +8,7 @@
 import com.alibaba.ttl3.agent.transformlet.internal.TimerTaskTtlTransformlet;
 import com.alibaba.ttl3.executor.TtlExecutors;
 import edu.umd.cs.findbugs.annotations.NonNull;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
 import java.lang.instrument.ClassFileTransformer;
 import java.lang.instrument.Instrumentation;
@@ -365,6 +366,7 @@ static List<String> getOptionStringListValues(@NonNull String key) {
     }
 
 
+    @SuppressFBWarnings("CT_CONSTRUCTOR_THROW")
     private TtlAgent() {
         throw new InstantiationError("Must not instantiate this class");
     }

diff --git a/ttl-agent/src/main/java/com/alibaba/ttl3/agent/TtlAgentHelper.java b/ttl-agent/src/main/java/com/alibaba/ttl3/agent/TtlAgentHelper.java
@@ -2,6 +2,7 @@
 
 import edu.umd.cs.findbugs.annotations.NonNull;
 import edu.umd.cs.findbugs.annotations.Nullable;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
 import java.util.*;
 
@@ -126,6 +127,7 @@ static List<String> splitListStringToStringList(@Nullable String listString) {
     }
 
 
+    @SuppressFBWarnings("CT_CONSTRUCTOR_THROW")
     private TtlAgentHelper() {
         throw new InstantiationError("Must not instantiate this class");
     }

diff --git a/...agent/src/main/java/com/alibaba/ttl3/agent/transformlet/helper/TtlTransformletHelper.java b/...agent/src/main/java/com/alibaba/ttl3/agent/transformlet/helper/TtlTransformletHelper.java
@@ -7,6 +7,7 @@
 import com.alibaba.ttl3.spi.TtlEnhanced;
 import edu.umd.cs.findbugs.annotations.NonNull;
 import edu.umd.cs.findbugs.annotations.Nullable;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import javassist.*;
 
 import java.lang.reflect.Modifier;
@@ -206,6 +207,7 @@ public static boolean isClassAtPackageJavaUtil(@NonNull String className) {
         return isClassAtPackage(className, "java.util");
     }
 
+    @SuppressFBWarnings("CT_CONSTRUCTOR_THROW")
     private TtlTransformletHelper() {
         throw new InstantiationError("Must not instantiate this class");
     }

diff --git a/ttl-core/src/main/java/com/alibaba/ttl3/TtlWrappers.java b/ttl-core/src/main/java/com/alibaba/ttl3/TtlWrappers.java
@@ -7,6 +7,7 @@
 import com.alibaba.ttl3.spi.TtlWrapper;
 import edu.umd.cs.findbugs.annotations.NonNull;
 import edu.umd.cs.findbugs.annotations.Nullable;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import org.jetbrains.annotations.Contract;
 
 import java.util.concurrent.Callable;
@@ -310,6 +311,7 @@ public String toString() {
         }
     }
 
+    @SuppressFBWarnings("CT_CONSTRUCTOR_THROW")
     private TtlWrappers() {
         throw new InstantiationError("Must not instantiate this class");
     }

diff --git a/ttl-core/src/main/java/com/alibaba/ttl3/executor/TtlExecutors.java b/ttl-core/src/main/java/com/alibaba/ttl3/executor/TtlExecutors.java
@@ -6,6 +6,7 @@
 import com.alibaba.ttl3.spi.TtlWrapper;
 import edu.umd.cs.findbugs.annotations.NonNull;
 import edu.umd.cs.findbugs.annotations.Nullable;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import org.jetbrains.annotations.Contract;
 
 import java.util.Comparator;
@@ -330,6 +331,7 @@ public static Comparator<Runnable> unwrapTtlRunnableUnwrapComparator(@Nullable C
         return ((TtlUnwrapComparator<Runnable>) comparator).unwrap();
     }
 
+    @SuppressFBWarnings("CT_CONSTRUCTOR_THROW")
     private TtlExecutors() {
         throw new InstantiationError("Must not instantiate this class");
     }

diff --git a/ttl-core/src/main/java/com/alibaba/ttl3/transmitter/ThreadLocalTransmitRegistry.java b/ttl-core/src/main/java/com/alibaba/ttl3/transmitter/ThreadLocalTransmitRegistry.java
@@ -2,6 +2,7 @@
 
 import com.alibaba.ttl3.TransmittableThreadLocal;
 import edu.umd.cs.findbugs.annotations.NonNull;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
 import java.util.HashMap;
 import java.util.Map;
@@ -199,6 +200,7 @@ public void restore(@NonNull HashMap<ThreadLocal<Object>, Object> backup) {
         TransmitteeRegistry.registerTransmittee(threadLocalTransmittee);
     }
 
+    @SuppressFBWarnings("CT_CONSTRUCTOR_THROW")
     private ThreadLocalTransmitRegistry() {
         throw new InstantiationError("Must not instantiate this class");
     }

diff --git a/ttl-core/src/main/java/com/alibaba/ttl3/transmitter/TransmitteeRegistry.java b/ttl-core/src/main/java/com/alibaba/ttl3/transmitter/TransmitteeRegistry.java
@@ -2,6 +2,7 @@
 
 import com.alibaba.ttl3.TransmittableThreadLocal;
 import edu.umd.cs.findbugs.annotations.NonNull;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
 /**
  * Transmittee(aka {@code ThreadLocal}) Integration,
@@ -50,6 +51,7 @@ public static <C, B> boolean unregisterTransmittee(@NonNull Transmittee<C, B> tr
         return Transmitter.compositeCrrTransmit.unregisterCrrTransmit(transmittee);
     }
 
+    @SuppressFBWarnings("CT_CONSTRUCTOR_THROW")
     private TransmitteeRegistry() {
         throw new InstantiationError("Must not instantiate this class");
     }

diff --git a/ttl-core/src/main/java/com/alibaba/ttl3/transmitter/Transmitter.java b/ttl-core/src/main/java/com/alibaba/ttl3/transmitter/Transmitter.java
@@ -269,6 +269,7 @@ public static boolean unregisterCallback(@NonNull CrrTransmitCallback callback)
         return compositeCallback.unregisterCallback(callback);
     }
 
+    @SuppressFBWarnings("CT_CONSTRUCTOR_THROW")
     private Transmitter() {
         throw new InstantiationError("Must not instantiate this class");
     }

diff --git a/ttl2-compatible/src/main/java/com/alibaba/ttl/TransmittableThreadLocal.java b/ttl2-compatible/src/main/java/com/alibaba/ttl/TransmittableThreadLocal.java
@@ -1083,6 +1083,7 @@ public static <T> boolean unregisterThreadLocal(@NonNull ThreadLocal<T> threadLo
 
         private static final TtlCopier<Object> shadowCopier = parentValue -> parentValue;
 
+        @SuppressFBWarnings("CT_CONSTRUCTOR_THROW")
         private Transmitter() {
             throw new InstantiationError("Must not instantiate this class");
         }

diff --git a/ttl2-compatible/src/main/java/com/alibaba/ttl/TtlUnwrap.java b/ttl2-compatible/src/main/java/com/alibaba/ttl/TtlUnwrap.java
@@ -2,6 +2,7 @@
 
 import com.alibaba.ttl.spi.TtlWrapper;
 import edu.umd.cs.findbugs.annotations.Nullable;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import org.jetbrains.annotations.Contract;
 
 /**
@@ -64,6 +65,7 @@ public static <T> boolean isWrapper(@Nullable T obj) {
         return obj instanceof TtlWrapper;
     }
 
+    @SuppressFBWarnings("CT_CONSTRUCTOR_THROW")
     private TtlUnwrap() {
         throw new InstantiationError("Must not instantiate this class");
     }

diff --git a/ttl2-compatible/src/main/java/com/alibaba/ttl/TtlWrappers.java b/ttl2-compatible/src/main/java/com/alibaba/ttl/TtlWrappers.java
@@ -4,6 +4,7 @@
 import com.alibaba.ttl.spi.TtlWrapper;
 import edu.umd.cs.findbugs.annotations.NonNull;
 import edu.umd.cs.findbugs.annotations.Nullable;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import org.jetbrains.annotations.Contract;
 
 import java.util.function.*;
@@ -433,6 +434,7 @@ public String toString() {
     }
 
 
+    @SuppressFBWarnings("CT_CONSTRUCTOR_THROW")
     private TtlWrappers() {
         throw new InstantiationError("Must not instantiate this class");
     }

diff --git a/ttl2-compatible/src/main/java/com/alibaba/ttl/threadpool/TtlExecutors.java b/ttl2-compatible/src/main/java/com/alibaba/ttl/threadpool/TtlExecutors.java
@@ -6,6 +6,7 @@
 import com.alibaba.ttl.threadpool.agent.TtlAgent;
 import edu.umd.cs.findbugs.annotations.NonNull;
 import edu.umd.cs.findbugs.annotations.Nullable;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import org.jetbrains.annotations.Contract;
 
 import java.util.Comparator;
@@ -297,6 +298,7 @@ public static Comparator<Runnable> unwrap(@Nullable Comparator<Runnable> compara
         return ((TtlUnwrapComparator<Runnable>) comparator).unwrap();
     }
 
+    @SuppressFBWarnings("CT_CONSTRUCTOR_THROW")
     private TtlExecutors() {
         throw new InstantiationError("Must not instantiate this class");
     }

diff --git a/ttl2-compatible/src/main/java/com/alibaba/ttl/threadpool/TtlForkJoinPoolHelper.java b/ttl2-compatible/src/main/java/com/alibaba/ttl/threadpool/TtlForkJoinPoolHelper.java
@@ -2,6 +2,7 @@
 
 import edu.umd.cs.findbugs.annotations.NonNull;
 import edu.umd.cs.findbugs.annotations.Nullable;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import org.jetbrains.annotations.Contract;
 
 import java.util.concurrent.ForkJoinPool;
@@ -83,6 +84,7 @@ public static ForkJoinWorkerThreadFactory unwrap(@Nullable ForkJoinWorkerThreadF
         return ((DisableInheritableForkJoinWorkerThreadFactory) threadFactory).unwrap();
     }
 
+    @SuppressFBWarnings("CT_CONSTRUCTOR_THROW")
     private TtlForkJoinPoolHelper() {
         throw new InstantiationError("Must not instantiate this class");
     }

diff --git a/ttl2-compatible/src/main/java/com/alibaba/ttl/threadpool/agent/TtlAgent.java b/ttl2-compatible/src/main/java/com/alibaba/ttl/threadpool/agent/TtlAgent.java
@@ -7,6 +7,7 @@
 import com.alibaba.ttl.threadpool.agent.transformlet.internal.TimerTaskTtlTransformlet;
 import com.alibaba.ttl.threadpool.agent.transformlet.internal.PriorityBlockingQueueTtlTransformlet;
 import edu.umd.cs.findbugs.annotations.NonNull;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
 import java.lang.instrument.ClassFileTransformer;
 import java.lang.instrument.Instrumentation;
@@ -376,6 +377,7 @@ static List<String> getOptionStringListValues(@NonNull String key) {
     }
 
 
+    @SuppressFBWarnings("CT_CONSTRUCTOR_THROW")
     private TtlAgent() {
         throw new InstantiationError("Must not instantiate this class");
     }

diff --git a/ttl2-compatible/src/main/java/com/alibaba/ttl/threadpool/agent/TtlAgentHelper.java b/ttl2-compatible/src/main/java/com/alibaba/ttl/threadpool/agent/TtlAgentHelper.java
@@ -2,6 +2,7 @@
 
 import edu.umd.cs.findbugs.annotations.NonNull;
 import edu.umd.cs.findbugs.annotations.Nullable;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
 import java.util.*;
 
@@ -127,6 +128,7 @@ static List<String> splitListStringToStringList(@Nullable String listString) {
     }
 
 
+    @SuppressFBWarnings("CT_CONSTRUCTOR_THROW")
     private TtlAgentHelper() {
         throw new InstantiationError("Must not instantiate this class");
     }

diff --git a/...main/java/com/alibaba/ttl/threadpool/agent/transformlet/helper/TtlTransformletHelper.java b/...main/java/com/alibaba/ttl/threadpool/agent/transformlet/helper/TtlTransformletHelper.java
@@ -7,6 +7,7 @@
 import com.alibaba.ttl.threadpool.agent.transformlet.TtlTransformlet;
 import edu.umd.cs.findbugs.annotations.NonNull;
 import edu.umd.cs.findbugs.annotations.Nullable;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import javassist.*;
 
 import java.lang.reflect.Modifier;
@@ -207,6 +208,7 @@ public static boolean isClassAtPackageJavaUtil(@NonNull String className) {
         return isClassAtPackage(className, "java.util");
     }
 
+    @SuppressFBWarnings("CT_CONSTRUCTOR_THROW")
     private TtlTransformletHelper() {
         throw new InstantiationError("Must not instantiate this class");
     }