Skip to content

Commit

Permalink
Merge pull request #90 from alice-biometrics/feature/report-attribute…
Browse files Browse the repository at this point in the history
…s-naming

feat(report): rename internal attributes
  • Loading branch information
LdeBerried committed Nov 14, 2023
2 parents c8af45e + 3f10648 commit 0633535
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
from alice.onboarding.models.report.compliance.device_out import DeviceOut


class UserEventOut(BaseModel):
class DomainEvent(BaseModel):
"""
It collects events info
Domain Event Information
"""

type: str = Field(description="Event type")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
from pydantic import BaseModel

from alice.onboarding.models.report.compliance.device_out import DeviceOut
from alice.onboarding.models.report.compliance.user_event_out import UserEventOut
from alice.onboarding.models.report.compliance.domain_event import DomainEvent


class DomainEventsReport(BaseModel):
devices: List[DeviceOut]
events: List[UserEventOut]
events: List[DomainEvent]
# num_devices: int
# total_time: float # seconds
4 changes: 2 additions & 2 deletions alice/onboarding/models/report/report.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

from pydantic import BaseModel, Field

from alice.onboarding.models.report.compliance.user_event_out import UserEventOut
from alice.onboarding.models.report.compliance.domain_event import DomainEvent
from alice.onboarding.models.report.document.document_report import DocumentReport
from alice.onboarding.models.report.other_trusted_document.other_trusted_document_report import (
OtherTrustedDocumentReport,
Expand Down Expand Up @@ -38,4 +38,4 @@ class Report(BaseModel):
description="It collects all user other trusted documents (bank receipts, proof of address...)",
default=[],
)
events: List[UserEventOut] = Field(description="It collects all user events")
events: List[DomainEvent] = Field(description="It collects all user events")

0 comments on commit 0633535

Please sign in to comment.