Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/flow features #71

Merged
merged 13 commits into from
Aug 9, 2023
Merged

Feature/flow features #71

merged 13 commits into from
Aug 9, 2023

Conversation

jask90
Copy link
Contributor

@jask90 jask90 commented Aug 9, 2023

No description provided.

@jask90 jask90 self-assigned this Aug 9, 2023
miguel-lorenzo
miguel-lorenzo requested changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@miguel-lorenzo miguel-lorenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mypy static analysis is failing

alice/onboarding/onboarding.py Outdated Show resolved Hide resolved
alice/onboarding/onboarding.py Outdated Show resolved Hide resolved
alice/onboarding/onboarding.py Outdated Show resolved Hide resolved
alice/onboarding/onboarding.py Outdated Show resolved Hide resolved
alice/onboarding/onboarding.py Outdated Show resolved Hide resolved
alice/onboarding/onboarding_client.py Outdated Show resolved Hide resolved
alice/onboarding/onboarding_client.py Outdated Show resolved Hide resolved
alice/onboarding/onboarding_client.py Outdated Show resolved Hide resolved
alice/onboarding/onboarding_client.py Outdated Show resolved Hide resolved
alice/onboarding/onboarding_client.py Outdated Show resolved Hide resolved
@miguel-lorenzo miguel-lorenzo marked this pull request as ready for review August 9, 2023 07:53
@jask90
Copy link
Contributor Author

jask90 commented Aug 9, 2023

@miguel-lorenzo test_should_do_complete_flow_process fails because create_flow responds with a bool from new-onboarding, so I understand that the tests go against new-onboarding production. This code should work correctly after deploying the latest version of new-onboarding to production.

@miguel-lorenzo miguel-lorenzo self-requested a review August 9, 2023 10:07
@miguel-lorenzo miguel-lorenzo merged commit 3750164 into main Aug 9, 2023
0 of 10 checks passed
@miguel-lorenzo miguel-lorenzo deleted the feature/flow-features branch August 9, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguel-lorenzo miguel-lorenzo miguel-lorenzo approved these changes

Assignees

@jask90 jask90

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jask90 @miguel-lorenzo