Skip to content

[node] sfmFilter : Add new option to remove unselected poses #1932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

[node] sfmFilter : Add new option to remove unselected poses #1932

wants to merge 3 commits into from

Conversation

Alxiice
Copy link
Contributor

@Alxiice Alxiice commented Jul 29, 2025 •
edited
Loading

  • Add a new parameter prunePoses in the sfmFilter node.
    • If set to True, then we will also split the poses in the selected/unslected sfm files

@Alxiice Alxiice added this to the 3.3.0 milestone Jul 29, 2025
@Alxiice Alxiice changed the title [node] sfmFilter : Add new removeUnselectedPoses option [node] sfmFilter : Add new option to remove unselected poses Jul 29, 2025
@Alxiice Alxiice marked this pull request as ready for review July 29, 2025 09:01
@Alxiice Alxiice force-pushed the dev/add_removeUnselectedPoses_to_sfmFilter branch from bd5da8a to cbec642 Compare July 29, 2025 09:03
@Alxiice Alxiice requested a review from fabiencastan July 30, 2025 13:30
servantftransperfect
servantftransperfect requested changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@servantftransperfect servantftransperfect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rewrite sfmFilter to do that for all objects, without options.

@cbentejac cbentejac modified the milestones: 3.3.0, 3.4.0 Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@servantftransperfect servantftransperfect servantftransperfect requested changes

@cbentejac cbentejac Awaiting requested review from cbentejac

@fabiencastan fabiencastan Awaiting requested review from fabiencastan

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Alxiice @servantftransperfect @cbentejac