-
-
Notifications
You must be signed in to change notification settings - Fork 851
Bootstrap with injected depths from Depthmaps #1994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
12f4da3
to
f8c3bbf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
if (bestPairId == UndefinedIndexT) | ||
{ | ||
ALICEVISION_LOG_INFO("No valid pair"); | ||
return EXIT_FAILURE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should return false
instead of EXIT_FAILURE
to match the function's return type and be consistent with other error returns in the same function.
return EXIT_FAILURE; | |
return false; |
Copilot uses AI. Check for mistakes.
* @param otherTreference the relative pose | ||
* @param tracksMap the input map of tracks | ||
* @param tracksPerView tracks grouped by views | ||
* @return true | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parameter name in the documentation (otherTreference
) doesn't match the actual parameter name in the function signature. The function doesn't have this parameter.
* @param otherTreference the relative pose | |
* @param tracksMap the input map of tracks | |
* @param tracksPerView tracks grouped by views | |
* @return true | |
*/ | |
* @param tracksMap the input map of tracks | |
* @param tracksPerView tracks grouped by views | |
* @return true | |
*/ |
Copilot uses AI. Check for mistakes.
This is a first bootstrapping solution for depthmaps. It is very basic at the moment and should be improved over time !
This pull request introduces a new "depth" bootstrapping method to the Structure-from-Motion (SfM) pipeline, alongside the existing "classic" and "mesh" methods. It adds the necessary infrastructure to handle depth-based bootstrapping, including new C++ logic, Python interface updates, and supporting utilities for constructing SfM data from depth maps. The changes are grouped below by theme.
New bootstrapping method: "depth"
method
(choices: "classic", "mesh", "depth") to theSfMBootStrapping
node in the Python interface, allowing users to select the bootstrapping approach. The mesh file parameter is now only enabled if the "mesh" method is selected. [1] [2]EBOOTSTRAPMETHOD
and a string-to-enum conversion utility to handle the new method in the C++ pipeline entry point.Depth-based bootstrapping implementation
bootstrapDepth
function, which constructs initial camera poses and landmarks using depth information from tracks, and integrates it into the bootstrapping pipeline. [1] [2]buildSfmDataFromDepthMap
in new filesTracksDepths.cpp
andTracksDepths.hpp
, providing utilities to build minimal SfMData objects from depth maps for a given view. [1] [2]Pair selection using depth information
findBestPairFromTrackDepths
to select the best initial image pair using depth information, with supporting documentation and logic. [1] [2]Supporting API improvements
getViewSharedPtr
inSfMData
to facilitate safe access during depth-based operations.