[core] Handle missing link nodes when deserializing edges

Avoid uncaught errors when deserializing edges in case linked nodes are missing. Handle missing nodes the same way missing attributes are dealt with.
alicevision · Jan 28, 2025 · f224afc · f224afc
1 parent 0d5aa6c
commit f224afc
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/meshroom/core/attribute.py b/meshroom/core/attribute.py
@@ -330,9 +330,12 @@ def _applyExpr(self):
         elif self.isInput and Attribute.isLinkExpression(v):
             # value is a link to another attribute
             link = v[1:-1]
-            linkNode, linkAttr = link.split('.')
+            linkNodeName, linkAttrName = link.split('.')
             try:
-                g.addEdge(g.node(linkNode).attribute(linkAttr), self)
+                node = g.node(linkNodeName)
+                if not node:
+                    raise KeyError(f"Node '{linkNodeName}' not found")
+                g.addEdge(node.attribute(linkAttrName), self)
             except KeyError as err:
                 logging.warning('Connect Attribute from Expression failed.')
                 logging.warning('Expression: "{exp}"\nError: "{err}".'.format(exp=v, err=err))

diff --git a/tests/test_graphIO.py b/tests/test_graphIO.py
@@ -336,3 +336,15 @@ def test_nodeWithoutVersionInfoIsUpgraded(self):
             assert len(graph.nodes) == 1
             assert len(graph.compatibilityNodes) == 0
 
+    def test_connectionsToMissingNodesAreDiscarded(self):
+        graph = Graph("")
+
+        with registeredNodeTypes([SimpleNode]):
+            sampleGraphContent = dedent("""
+            {
+                "SimpleNode_1": { 
+                    "nodeType": "SimpleNode", "inputs": { "input": "{NotSerializedNode.output}" } 
+                }
+            }
+            """)
+            graph._deserialize(json.loads(sampleGraphContent))