Distortion Parameter details

[natowi]

Description

Clarifying Distortion Parameter order

Related to
#1647
#1484

[servantftechnicolor]

This description depends on the camera model choosen. Definitly not a constant description.

[natowi]

@servantftechnicolor In that case it would be great if you could provide more details

I found this - does the order apply for this node as well?:

1: Pinhole => 3 parameters (focal, principal point x, principal point y)
2: Pinhole radial 1 => 4 params (focal, principal point x, principal point y, one radial distortion factor)
3: Pinhole radial 3 (default) => 6 params (focal, principal point x, principal point y, 3 radial distortion factors)
4: Pinhole brown 2 => 8 params (focal, principal point x, principal point y, 5 distortion factors (3radial+2 tangential))
5: Pinhole with a simple Fish-eye distortion => 7 params (focal, principal point x, principal point y, 4 distortion factors)
openMVG/openMVG#678 (comment)
https://openmvg.readthedocs.io/en/latest/openMVG/cameras/cameras/#pinhole-camera-model

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[simogasp]

we need to put this info somewhere.
I had started to compile something like this

I need to complete it with the 3DE models but then we should put it in the Doxygen of each class and in the main doc

[natowi]

The 3de parameters can be taken fom here: https://github.com/alicevision/AliceVision/blob/develop/src/aliceVision/camera/Pinhole3DE.hpp
https://github.com/alicevision/AliceVision/blob/develop/src/aliceVision/camera/Distortion3DE.hpp

I found documentation for the 3de models:
https://www.3dequalizer.com/user_daten/tech_docs/pdf/ldpk.pdf
https://www.3dequalizer.com/user_daten/tech_docs/pdf/distortion.pdf

This is also a good reference: https://github.com/NatronGitHub/openfx-misc/tree/master/Distortion