[ui][fix] Application Menubar: Ensure Menubar occupies all of available height of the layout #2643
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #2643 +/- ##
========================================
Coverage 69.95% 69.95%
========================================
Files 122 122
Lines 7106 7106
========================================
Hits 4971 4971
Misses 2135 2135 ☔ View full report in Codecov by Sentry. |
|
The main issue I have with this change is that, although the menu bar now takes up the whole space as it should, the menus themselves are not vertically centered with the homepage icon. The menu bar starts slightly higher than the homepage button but finishes slightly higher as well, and it's very clear when hovering. It'd be great if the button and the menu bar could be aligned. |
waaake
force-pushed
the
fix/MenuBarHeight
branch
from
75b8ac2 to
21ed191
Compare
meshroom/ui/qml/Application.qml
Outdated
| MenuBar { | ||
| palette.window: Qt.darker(activePalette.window, 1.15) | ||
| anchors.bottom: parent.bottom | ||
| anchors.bottomMargin: 1 /// this margin counters the offset vertically when lining up against with the homeButton |
There was a problem hiding this comment.
Looks better to me without this offset.
| anchors.bottomMargin: 1 /// this margin counters the offset vertically when lining up against with the homeButton |
meshroom/ui/qml/Application.qml
Outdated
|
|
||
| MenuBar { | ||
| palette.window: Qt.darker(activePalette.window, 1.15) | ||
| anchors.bottom: parent.bottom |
There was a problem hiding this comment.
if we could avoid anchors that's ideal.
meshroom/ui/qml/Application.qml
Outdated
| Rectangle { | ||
| /** | ||
| * This Rectangle serves as the parent of the menubar | ||
| * occupying all of the additional space which the MenuBar is not going to get | ||
| */ | ||
| Layout.fillWidth: true | ||
| Layout.fillHeight: true | ||
| color: Qt.darker(activePalette.window, 1.15) | ||
|
|
There was a problem hiding this comment.
Just using "height: parent.height" on the MenuBar seems to work, without adding a Rectangle into the hierarchy.
There was a problem hiding this comment.
This rectangle already existed to cover up additional space horizontally, but I could try using height property to set this, last I can recall, there was a very minor pixel worth of offset against the Custom buttons. Let me try the changes, thanks.
waaake
force-pushed
the
fix/MenuBarHeight
branch
from
21ed191 to
5f77674
Compare
…hbours Added a base rectangle serving as the header for the Application. The Child Buttons now get a icon color change on hover Relaced Rectangle Spacer with Item to get the color from background rect Fixed the height of the Menubar to occupy available height
waaake
force-pushed
the
fix/MenuBarHeight
branch
from
5f77674 to
7dc2eff
Compare
Description
This PR modifies the
Menubarcomponent to ensure it fills the layout in terms of height.The change addresses an inconsistency where the MenuBar did not align with the Parent's dimensions.
Details of the change
The above changes ensure the overall alignment of the Header bar elements, Custom buttons and MenuBar.
Appearence after the changes