Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSP behaviour options #1434

Merged
merged 11 commits into from
Feb 3, 2025
Merged

CSP behaviour options #1434

merged 11 commits into from
Feb 3, 2025

Conversation

TheOrangePuff
Copy link
Contributor

Description of the proposed changes

  • Adds config to allow adding csp to specific paths. This will allow checkout to have it's own unique CSP.
  • Due to the length of our CSP headers, adding CSP requires the use of Lambda@Edge functions

Notes to reviewers

🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback

Copy link
Contributor

@AdamJHall AdamJHall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple of small suggests and one change needed in the csp paths map.

packages/static-hosting/lib/csp.ts Outdated Show resolved Hide resolved
packages/static-hosting/lib/static-hosting.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@AdamJHall AdamJHall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 😎

@TheOrangePuff TheOrangePuff merged commit 64aa74c into main Feb 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants