Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use peer dependencies #1440

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Use peer dependencies #1440

merged 2 commits into from
Feb 10, 2025

Conversation

TheOrangePuff
Copy link
Contributor

Description of the proposed changes

  • Change all our constructs to use peer dependencies and lock to a major version of cdk
  • This should allow us to change the version of cdk in repos that use these constructs, rather than being forced to use the version the construct is written in

Notes to reviewers

🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback

Copy link
Contributor

@aaronmedina-dev aaronmedina-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TheOrangePuff TheOrangePuff merged commit bed934b into main Feb 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants