tolist attempts to split default value. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olist will fail if that argument was not provided. i.e. def foo(moo=[]): pass decorated will fail with an attribute error 'list' object has no attribute split. This change compares the input value with the original value to see if it is different. TODO: probably best to check type?
|
Is the problem when the value is not provided or when it is? It looks like convert is already ignoring default arguments, and I only see the error when I call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When begin.conver(_automatic=True) and our default value is is set, tolist will fail if that argument was not provided. i.e. def foo(moo=[]): pass decorated will fail with an attribute error 'list' object has no attribute split. This change compares the input value with the original value to see if it is different. TODO: probably best to check type?