Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When submodules are defined, require a submodule. #60

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

sh0oki
Copy link

@sh0oki sh0oki commented Oct 9, 2016

Resolves #48.

Elisha and others added 3 commits October 10, 2016 02:25
Reorder code in cmdline:create_parser to correct a bug where the config_section setting was being ignored for the main function when subcommands are used. (The subcommand setup is overwriting the config section used by populate_parser, so do it after setting up the main function.)
@jrwdunham
Copy link

What needs to happen in order for this to get merged? I for one would like to see #48 resolved.

@sh0oki
Copy link
Author

sh0oki commented Nov 5, 2016

It seems @aliles is inactive on Github for some time.
You're welcome to use my branch (which fixes the issue) in the meanwhile...

@coveralls
Copy link

coveralls commented Jan 7, 2017

Coverage Status

Coverage decreased (-2.2%) to 96.68% when pulling 2006c43 on sh0oki:master into 23bc0d8 on aliles:master.

@coveralls
Copy link

coveralls commented Jan 23, 2017

Coverage Status

Coverage decreased (-2.2%) to 96.667% when pulling 6858946 on sh0oki:master into 23bc0d8 on aliles:master.

@coveralls
Copy link

coveralls commented Jan 24, 2017

Coverage Status

Coverage decreased (-2.2%) to 96.667% when pulling 6f42919 on sh0oki:master into 23bc0d8 on aliles:master.

@lispsteve
Copy link

Hi, is there any plan to resolve this bug?

@coveralls
Copy link

coveralls commented Apr 21, 2017

Coverage Status

Coverage decreased (-3.04%) to 95.866% when pulling fdf78e2 on sh0oki:master into 23bc0d8 on aliles:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants