Reuse hashing mechanism to regen config in sandboxed mode #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosteo
force-pushed
the
fix/sandboxed-config
branch
2 times, most recently
from
1c5aac2
to
6879428
Compare
Fabien-Chouteau
approved these changes
Sep 1, 2023
Leverage the new build hashing to make sure when a configuration needs regenerating. This is pessimistic but safer than what we had, and more future-proof.
mosteo
force-pushed
the
fix/sandboxed-config
branch
from
6879428
to
4292353
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts to rest some corner irksome behaviors we had with config being regenerated too many times and yet not always when needed. By using the same build hashes internally, we have a conservative safe way to know when to regenerate configs.
Also fixes #1355