Run delayed post-fetch actions during build #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post-fetch actions are now delayed until build time (still being run only once). With this we ensure that the configuration/environment is complete and these actions operate with the same environment as other actions.
This fixes post-fetch for both shared dependencies and sandboxed dependencies, although for different reasons: for the former, they weren't run at all due to a previous PR. For the latter, they could be run with incomplete config and fail unexpectedly, leaving the dependency in a half-deployed state.
File flags for the management of release deployment completion and post-fetch completion have been refactored to their own crate.
With this the new shared dependencies are feature complete and ready for general testing.