Cleanup after shared releases impl #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we delay all actions to build time, we can set environment just at that time and avoid complications.
mosteo
force-pushed
the
feat/shared-cleanup
branch
from
580634e
to
7d3c51b
Compare
Fabien-Chouteau
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now always run actions no sooner than build time and that simplifies when we need to export the environment, which was somewhat scattered and hard to understand/maintain. This can now be removed.
Added also some extra checks that may come in handy if we get reports wrt the new shared dependencies (although the reason for these should fixed in #1445).