Interpret environment entries as path parts
#1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosteo
force-pushed
the
fix/slashes-simple
branch
2 times, most recently
from
c17f2a8
to
df1c436
Compare
mosteo
force-pushed
the
fix/slashes-simple
branch
2 times, most recently
from
29e9e16
to
0fcf892
Compare
mosteo
force-pushed
the
fix/slashes-simple
branch
from
0fcf892
to
e13741b
Compare
This is the likely intended behavior. Down the road we can have a way to have literal values in these strings.
mosteo
force-pushed
the
fix/slashes-simple
branch
from
e13741b
to
058e787
Compare
mosteo
force-pushed
the
fix/slashes-simple
branch
from
52b96b3
to
7218070
Compare
Fabien-Chouteau
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #1178, by mandating
'/'path separators in environment values for dir separation.I expect user intent is always (99.9%?) to have slashes be interpreted as path separators in environment entries. We had some conditional expressions in our test indexes, but none in our current community releases, so we were already operating under the above assumption. We could provide a way down the road to avoid this path interpretation, but it seems a pretty marginal use case.
This is a breaking reinterpretation, so in time for
2.0.