Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for full publishing workflow #1538

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Conversation

mosteo
Copy link
Member

@mosteo mosteo commented Jan 21, 2024

This test goes online and creates a PR against a test index on github, so we probably don't want to run it every time but locally and sporadically, or just before a release. For that reason it belongs to a new class of 'local' tests that are normally skipped unless enabled explicitly.

Goes on top of #1537

This test is dependent on a remote repo (`test-index`) on which a PR is opened
during testing, so we better run this one sporadically and locally, or in a
single selected CI configuration.
@mosteo mosteo marked this pull request as ready for review January 24, 2024 20:32
@@ -57,6 +57,9 @@ no matter their value, or lack of one.
- `ALIRE_DISABLE_NETWORK_TESTS`: when defined, tests that
require non-local network use will be skipped.

- `ALIRE_ENABLE_LOCAL_TESTS`: when defined, tests that are intended to be run
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to prefix this testsuite variables with ALIRE_TESTSUITE_ instead of ALIRE_

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed.

@mosteo mosteo merged commit 68dc176 into alire-project:master Feb 15, 2024
14 checks passed
@mosteo mosteo deleted the test/submit branch February 15, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants