Better documentation for binary origins #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fabien-Chouteau
approved these changes
Jan 29, 2024
| @@ -455,6 +455,12 @@ static, i.e. they cannot depend on the context. | |||
| several crates from the same repository (sometimes referred to as a | |||
| *monorepo*). | |||
|
|
|||
| - `binary`: optional (defauts to false) boolean used to design the origin | |||
There was a problem hiding this comment.
Maybe we can disable implicit detection then?
There was a problem hiding this comment.
This will require editing all binary releases in the index. We are due for an index version bump with the 2.0 release, so that would be a good moment.
There was a problem hiding this comment.
It would make things more clear for everyone I think.
|
I'm going to merge this one as-is and work on the explicit binary flag in a follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And a bonus test.
Fixes #1512