Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependencies in testsuite documentation. #1620

Conversation

rocher
Copy link
Contributor

@rocher rocher commented Mar 9, 2024

Required package pexpect is not installed as a dependency of e3-testsuite, so is has to be explicitly installed.

Neither e3-testsuite nor e3-core depend on it:

$ pip show e3-testsuite e3-core
Name: e3-testsuite
Version: 26.0
Summary: E3 testsuite
Home-page:
Author: AdaCore
Author-email: [email protected]
License: GPLv3
Location: /home/ada/opt/alire/venv/lib/python3.10/site-packages Requires: e3-core
Required-by:
---
Name: e3-core
Version: 22.4.0
Summary: E3 core. Tools and library for building and testing software Home-page: https://github.com/AdaCore/e3-core
Author: AdaCore
Author-email: [email protected]
License: GPLv3
Location: /home/ada/opt/alire/venv/lib/python3.10/site-packages Requires: colorama, ld, packaging, psutil, python-dateutil, pyyaml, requests, requests-cache, requests-toolbelt, setuptools, stevedore, tqdm
Required-by: e3-testsuite

Required package 'pexpect' is not installed as a dependency of
'e3-testsuite', so is has to be explicitly installed.

Neither 'e3-testsuite' nor 'e3-core' depend on it:

$ pip show e3-testsuite e3-core
Name: e3-testsuite
Version: 26.0
Summary: E3 testsuite
Home-page:
Author: AdaCore
Author-email: [email protected]
License: GPLv3
Location: /home/ada/opt/alire/venv/lib/python3.10/site-packages
Requires: e3-core
Required-by:
---
Name: e3-core
Version: 22.4.0
Summary: E3 core. Tools and library for building and testing software
Home-page: https://github.com/AdaCore/e3-core
Author: AdaCore
Author-email: [email protected]
License: GPLv3
Location: /home/ada/opt/alire/venv/lib/python3.10/site-packages
Requires: colorama, ld, packaging, psutil, python-dateutil, pyyaml, requests, requests-cache, requests-toolbelt, setuptools, stevedore, tqdm
Required-by: e3-testsuite
@mosteo
Copy link
Member

mosteo commented Mar 9, 2024

That's a good catch, @rocher, but actually the (now) proper advice is to use the requirements.txt file, which is up to date: pip install -r requirements.txt

Copy link
Member

@mosteo mosteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my other comment.

@rocher
Copy link
Contributor Author

rocher commented Mar 9, 2024

Didn't see requirements.txt file. Much better solution, indeed.

@mosteo mosteo merged commit 3245eeb into alire-project:master Mar 9, 2024
1 check passed
@mosteo
Copy link
Member

mosteo commented Mar 9, 2024

Thanks, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants