-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add -j $JOBS to the CMake invocations missing it #5698
Open
singiamtel
wants to merge
5
commits into
alisw:master
Choose a base branch
from
singiamtel:cmake_jobs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also addressing some linting changes
Maybe we could link this to some useful update, like bumping fmt or a newer version of ninja? |
Good idea, I'll try to bump as many as possible
fmt error:
|
ktf
reviewed
Nov 28, 2024
faircmakemodules.sh
Outdated
|
||
# Modulefile | ||
mkdir -p etc/modulefiles | ||
cat > etc/modulefiles/$PKGNAME <<EoF | ||
cat > etc/modulefiles/"$PKGNAME" <<EoF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can remove this completely and simply use alibuild-generate-module (see other places)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also addressing some linting changes
This will trigger a big rebuild, we should run the Cache Jenkins job on merge