Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -j $JOBS to the CMake invocations missing it #5698

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

singiamtel
Copy link
Collaborator

Also addressing some linting changes

This will trigger a big rebuild, we should run the Cache Jenkins job on merge

Also addressing some linting changes
@singiamtel singiamtel requested a review from a team as a code owner November 26, 2024 11:14
@ktf
Copy link
Member

ktf commented Nov 27, 2024

Maybe we could link this to some useful update, like bumping fmt or a newer version of ninja?

@singiamtel
Copy link
Collaborator Author

singiamtel commented Nov 28, 2024

Good idea, I'll try to bump as many as possible

  • ninja: no update
  • fmt: compilation error
  • catch2
  • faircmakemodules: no update

fmt error:

/sw/slc9_x86-64/fmt/11.0.2-local1/include/fmt/base.h:1402:29: error: passing 'const fmt::v11::formatter<o2::header::Descriptor<16>, char, void>' as 'this' argument discards qualifiers [-fpermissive]
 1402 |     ctx.advance_to(cf.format(*static_cast<qualified_type*>(arg), ctx));
      |                    ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


# Modulefile
mkdir -p etc/modulefiles
cat > etc/modulefiles/$PKGNAME <<EoF
cat > etc/modulefiles/"$PKGNAME" <<EoF
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove this completely and simply use alibuild-generate-module (see other places)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants