Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pip requirements on newer pythons #5727

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

singiamtel
Copy link
Collaborator

CC @Barthelemy, should fix the build with new Python versions

I got these from the current Python-modules-list recipe

@singiamtel singiamtel requested a review from a team as a code owner January 6, 2025 09:11
Copy link
Contributor

@Barthelemy Barthelemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, seems good.

@ktf
Copy link
Member

ktf commented Jan 7, 2025

@singiamtel, do you understand why rivet breaks in python?

@singiamtel
Copy link
Collaborator Author

@singiamtel, do you understand why rivet breaks in python?

I think it's a problem with Python-modules, we have a broken symlink in Python-modules on Linux when using Docker to build

# my machine
$ ls -ltra Python-modules/latest/bin
...
lrwxr-xr-x@  1 admin  staff    44B Jan  4 16:38 python3.13 -> /opt/homebrew/opt/[email protected]/bin/python3.13

# the builder
$ ls -ltra Python-modules/latest/bin
...
lrwxrwxrwx. 1 mesosci mesosci   49 Jan  7 09:19 python3 -> /sw/slc7_x86-64/Python/v3.9.16-local1/bin/python3 # this path doesn't exist on the host

I'm not sure why it doesn't affect all builds, but I believe it's the same issue that #5622 has, or the daily builds on Jenkins

I guess it's related to how we create the venv? Maybe we'll need to relocate the symlink manually https://github.com/alisw/alidist/blob/master/python-modules.sh#L27

@ktf ktf merged commit 6fa1566 into alisw:master Jan 9, 2025
13 checks passed
@singiamtel singiamtel deleted the python_o2_dataflow branch January 9, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants