Skip to content

Commit

Permalink
Upgrade ot version to v1.10.0
Browse files Browse the repository at this point in the history
  • Loading branch information
qiansheng91 committed Sep 14, 2022
1 parent ee3d69e commit 999ce03
Show file tree
Hide file tree
Showing 9 changed files with 718 additions and 220 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,4 @@ examples/opentelemetry-mux/opentelemetry-mux

# Dependency directories (remove the comment below to include it)
# vendor/
.idea/
61 changes: 30 additions & 31 deletions examples/opentelemetry-http/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -5,46 +5,45 @@ go 1.17
require (
github.com/aliyun-sls/opentelemetry-go-provider-sls v0.4.0
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.28.0
go.opentelemetry.io/otel v1.4.0
go.opentelemetry.io/otel/metric v0.27.0
go.opentelemetry.io/otel/trace v1.4.0
go.opentelemetry.io/otel v1.10.0
go.opentelemetry.io/otel/metric v0.31.0
go.opentelemetry.io/otel/trace v1.10.0
)

require (
github.com/cenkalti/backoff/v4 v4.1.2 // indirect
github.com/cenkalti/backoff/v4 v4.1.3 // indirect
github.com/felixge/httpsnoop v1.0.2 // indirect
github.com/go-logr/logr v1.2.2 // indirect
github.com/go-logr/logr v1.2.3 // indirect
github.com/go-logr/stdr v1.2.2 // indirect
github.com/go-ole/go-ole v1.2.6 // indirect
github.com/golang/protobuf v1.5.2 // indirect
github.com/grpc-ecosystem/grpc-gateway v1.16.0 // indirect
github.com/lufia/plan9stats v0.0.0-20211012122336-39d0f177ccd0 // indirect
github.com/power-devops/perfstat v0.0.0-20210106213030-5aafc221ea8c // indirect
github.com/sethvargo/go-envconfig v0.3.2 // indirect
github.com/shirou/gopsutil/v3 v3.21.11 // indirect
github.com/tklauser/go-sysconf v0.3.9 // indirect
github.com/tklauser/numcpus v0.3.0 // indirect
github.com/grpc-ecosystem/grpc-gateway/v2 v2.11.3 // indirect
github.com/lufia/plan9stats v0.0.0-20220913051719-115f729f3c8c // indirect
github.com/power-devops/perfstat v0.0.0-20220216144756-c35f1ee13d7c // indirect
github.com/sethvargo/go-envconfig v0.8.2 // indirect
github.com/shirou/gopsutil/v3 v3.22.8 // indirect
github.com/tklauser/go-sysconf v0.3.10 // indirect
github.com/tklauser/numcpus v0.5.0 // indirect
github.com/yusufpapurcu/wmi v1.2.2 // indirect
go.opentelemetry.io/contrib/instrumentation/host v0.27.0 // indirect
go.opentelemetry.io/contrib/instrumentation/runtime v0.27.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/internal/retry v1.4.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlpmetric v0.27.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v0.27.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.4.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.4.0 // indirect
go.opentelemetry.io/otel/exporters/stdout/stdoutmetric v0.27.0 // indirect
go.opentelemetry.io/otel/exporters/stdout/stdouttrace v1.4.0 // indirect
go.opentelemetry.io/otel/internal/metric v0.27.0 // indirect
go.opentelemetry.io/otel/sdk v1.4.0 // indirect
go.opentelemetry.io/otel/sdk/export/metric v0.27.0 // indirect
go.opentelemetry.io/otel/sdk/metric v0.27.0 // indirect
go.opentelemetry.io/proto/otlp v0.12.0 // indirect
golang.org/x/net v0.0.0-20211201190559-0a0e4e1bb54c // indirect
golang.org/x/sys v0.0.0-20211124211545-fe61309f8881 // indirect
go.opentelemetry.io/contrib/instrumentation/host v0.35.0 // indirect
go.opentelemetry.io/contrib/instrumentation/runtime v0.35.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/internal/retry v1.10.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlpmetric v0.31.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v0.31.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.10.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.10.0 // indirect
go.opentelemetry.io/otel/exporters/stdout/stdoutmetric v0.31.0 // indirect
go.opentelemetry.io/otel/exporters/stdout/stdouttrace v1.10.0 // indirect
go.opentelemetry.io/otel/sdk v1.10.0 // indirect
go.opentelemetry.io/otel/sdk/export/metric v0.28.0 // indirect
go.opentelemetry.io/otel/sdk/metric v0.31.0 // indirect
go.opentelemetry.io/proto/otlp v0.19.0 // indirect
golang.org/x/net v0.0.0-20220909164309-bea034e7d591 // indirect
golang.org/x/sys v0.0.0-20220913175220-63ea55921009 // indirect
golang.org/x/text v0.3.7 // indirect
google.golang.org/genproto v0.0.0-20211129164237-f09f9a12af12 // indirect
google.golang.org/grpc v1.44.0 // indirect
google.golang.org/protobuf v1.27.1 // indirect
google.golang.org/genproto v0.0.0-20220913154956-18f8339a66a5 // indirect
google.golang.org/grpc v1.49.0 // indirect
google.golang.org/protobuf v1.28.1 // indirect
)

replace github.com/aliyun-sls/opentelemetry-go-provider-sls => ../../
3 changes: 1 addition & 2 deletions examples/opentelemetry-http/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import (
"github.com/aliyun-sls/opentelemetry-go-provider-sls/provider"

"go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp"
"go.opentelemetry.io/otel/metric"
"go.opentelemetry.io/otel/trace"
)

Expand All @@ -50,7 +49,7 @@ func main() {
attribute.String("label1", "value1"),
}
meter := global.Meter("aliyun.sls")
sayDavidCount := metric.Must(meter).NewInt64Counter("say_david_count")
sayDavidCount, _ := meter.SyncInt64().Counter("say_david_count")

helloHandler := func(w http.ResponseWriter, req *http.Request) {
if time.Now().Unix()%10 == 0 {
Expand Down
61 changes: 30 additions & 31 deletions examples/opentelemetry-mux/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -6,46 +6,45 @@ require (
github.com/aliyun-sls/opentelemetry-go-provider-sls v0.4.0
github.com/gorilla/mux v1.8.0
go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux v0.28.0
go.opentelemetry.io/otel v1.4.0
go.opentelemetry.io/otel/metric v0.27.0
go.opentelemetry.io/otel/trace v1.4.0
go.opentelemetry.io/otel v1.10.0
go.opentelemetry.io/otel/metric v0.31.0
go.opentelemetry.io/otel/trace v1.10.0
)

require (
github.com/cenkalti/backoff/v4 v4.1.2 // indirect
github.com/cenkalti/backoff/v4 v4.1.3 // indirect
github.com/felixge/httpsnoop v1.0.2 // indirect
github.com/go-logr/logr v1.2.2 // indirect
github.com/go-logr/logr v1.2.3 // indirect
github.com/go-logr/stdr v1.2.2 // indirect
github.com/go-ole/go-ole v1.2.6 // indirect
github.com/golang/protobuf v1.5.2 // indirect
github.com/grpc-ecosystem/grpc-gateway v1.16.0 // indirect
github.com/lufia/plan9stats v0.0.0-20211012122336-39d0f177ccd0 // indirect
github.com/power-devops/perfstat v0.0.0-20210106213030-5aafc221ea8c // indirect
github.com/sethvargo/go-envconfig v0.3.2 // indirect
github.com/shirou/gopsutil/v3 v3.21.11 // indirect
github.com/tklauser/go-sysconf v0.3.9 // indirect
github.com/tklauser/numcpus v0.3.0 // indirect
github.com/grpc-ecosystem/grpc-gateway/v2 v2.11.3 // indirect
github.com/lufia/plan9stats v0.0.0-20220913051719-115f729f3c8c // indirect
github.com/power-devops/perfstat v0.0.0-20220216144756-c35f1ee13d7c // indirect
github.com/sethvargo/go-envconfig v0.8.2 // indirect
github.com/shirou/gopsutil/v3 v3.22.8 // indirect
github.com/tklauser/go-sysconf v0.3.10 // indirect
github.com/tklauser/numcpus v0.5.0 // indirect
github.com/yusufpapurcu/wmi v1.2.2 // indirect
go.opentelemetry.io/contrib/instrumentation/host v0.27.0 // indirect
go.opentelemetry.io/contrib/instrumentation/runtime v0.27.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/internal/retry v1.4.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlpmetric v0.27.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v0.27.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.4.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.4.0 // indirect
go.opentelemetry.io/otel/exporters/stdout/stdoutmetric v0.27.0 // indirect
go.opentelemetry.io/otel/exporters/stdout/stdouttrace v1.4.0 // indirect
go.opentelemetry.io/otel/internal/metric v0.27.0 // indirect
go.opentelemetry.io/otel/sdk v1.4.0 // indirect
go.opentelemetry.io/otel/sdk/export/metric v0.27.0 // indirect
go.opentelemetry.io/otel/sdk/metric v0.27.0 // indirect
go.opentelemetry.io/proto/otlp v0.12.0 // indirect
golang.org/x/net v0.0.0-20211201190559-0a0e4e1bb54c // indirect
golang.org/x/sys v0.0.0-20211124211545-fe61309f8881 // indirect
go.opentelemetry.io/contrib/instrumentation/host v0.35.0 // indirect
go.opentelemetry.io/contrib/instrumentation/runtime v0.35.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/internal/retry v1.10.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlpmetric v0.31.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v0.31.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.10.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.10.0 // indirect
go.opentelemetry.io/otel/exporters/stdout/stdoutmetric v0.31.0 // indirect
go.opentelemetry.io/otel/exporters/stdout/stdouttrace v1.10.0 // indirect
go.opentelemetry.io/otel/sdk v1.10.0 // indirect
go.opentelemetry.io/otel/sdk/export/metric v0.28.0 // indirect
go.opentelemetry.io/otel/sdk/metric v0.31.0 // indirect
go.opentelemetry.io/proto/otlp v0.19.0 // indirect
golang.org/x/net v0.0.0-20220909164309-bea034e7d591 // indirect
golang.org/x/sys v0.0.0-20220913175220-63ea55921009 // indirect
golang.org/x/text v0.3.7 // indirect
google.golang.org/genproto v0.0.0-20211129164237-f09f9a12af12 // indirect
google.golang.org/grpc v1.44.0 // indirect
google.golang.org/protobuf v1.27.1 // indirect
google.golang.org/genproto v0.0.0-20220913154956-18f8339a66a5 // indirect
google.golang.org/grpc v1.49.0 // indirect
google.golang.org/protobuf v1.28.1 // indirect
)

replace github.com/aliyun-sls/opentelemetry-go-provider-sls => ../../
3 changes: 1 addition & 2 deletions examples/opentelemetry-mux/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import (

"github.com/gorilla/mux"
"go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux"
"go.opentelemetry.io/otel/metric"
"go.opentelemetry.io/otel/trace"
)

Expand All @@ -50,7 +49,7 @@ func main() {
attribute.String("label1", "value1"),
}
meter := global.Meter("aliyun.sls")
callUsersCount := metric.Must(meter).NewInt64Counter("call_users_count")
callUsersCount, _ := meter.SyncInt64().Counter("call_users_count")

r := mux.NewRouter()
r.Use(otelmux.Middleware("my-server"))
Expand Down
61 changes: 30 additions & 31 deletions examples/opentelemetry-sample/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -4,45 +4,44 @@ go 1.17

require (
github.com/aliyun-sls/opentelemetry-go-provider-sls v0.4.0
go.opentelemetry.io/otel v1.4.0
go.opentelemetry.io/otel/metric v0.27.0
go.opentelemetry.io/otel/trace v1.4.0
go.opentelemetry.io/otel v1.10.0
go.opentelemetry.io/otel/metric v0.31.0
go.opentelemetry.io/otel/trace v1.10.0
)

require (
github.com/cenkalti/backoff/v4 v4.1.2 // indirect
github.com/go-logr/logr v1.2.2 // indirect
github.com/cenkalti/backoff/v4 v4.1.3 // indirect
github.com/go-logr/logr v1.2.3 // indirect
github.com/go-logr/stdr v1.2.2 // indirect
github.com/go-ole/go-ole v1.2.6 // indirect
github.com/golang/protobuf v1.5.2 // indirect
github.com/grpc-ecosystem/grpc-gateway v1.16.0 // indirect
github.com/lufia/plan9stats v0.0.0-20211012122336-39d0f177ccd0 // indirect
github.com/power-devops/perfstat v0.0.0-20210106213030-5aafc221ea8c // indirect
github.com/sethvargo/go-envconfig v0.3.2 // indirect
github.com/shirou/gopsutil/v3 v3.21.11 // indirect
github.com/tklauser/go-sysconf v0.3.9 // indirect
github.com/tklauser/numcpus v0.3.0 // indirect
github.com/grpc-ecosystem/grpc-gateway/v2 v2.11.3 // indirect
github.com/lufia/plan9stats v0.0.0-20220913051719-115f729f3c8c // indirect
github.com/power-devops/perfstat v0.0.0-20220216144756-c35f1ee13d7c // indirect
github.com/sethvargo/go-envconfig v0.8.2 // indirect
github.com/shirou/gopsutil/v3 v3.22.8 // indirect
github.com/tklauser/go-sysconf v0.3.10 // indirect
github.com/tklauser/numcpus v0.5.0 // indirect
github.com/yusufpapurcu/wmi v1.2.2 // indirect
go.opentelemetry.io/contrib/instrumentation/host v0.27.0 // indirect
go.opentelemetry.io/contrib/instrumentation/runtime v0.27.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/internal/retry v1.4.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlpmetric v0.27.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v0.27.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.4.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.4.0 // indirect
go.opentelemetry.io/otel/exporters/stdout/stdoutmetric v0.27.0 // indirect
go.opentelemetry.io/otel/exporters/stdout/stdouttrace v1.4.0 // indirect
go.opentelemetry.io/otel/internal/metric v0.27.0 // indirect
go.opentelemetry.io/otel/sdk v1.4.0 // indirect
go.opentelemetry.io/otel/sdk/export/metric v0.27.0 // indirect
go.opentelemetry.io/otel/sdk/metric v0.27.0 // indirect
go.opentelemetry.io/proto/otlp v0.12.0 // indirect
golang.org/x/net v0.0.0-20211201190559-0a0e4e1bb54c // indirect
golang.org/x/sys v0.0.0-20211124211545-fe61309f8881 // indirect
go.opentelemetry.io/contrib/instrumentation/host v0.35.0 // indirect
go.opentelemetry.io/contrib/instrumentation/runtime v0.35.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/internal/retry v1.10.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlpmetric v0.31.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v0.31.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.10.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.10.0 // indirect
go.opentelemetry.io/otel/exporters/stdout/stdoutmetric v0.31.0 // indirect
go.opentelemetry.io/otel/exporters/stdout/stdouttrace v1.10.0 // indirect
go.opentelemetry.io/otel/sdk v1.10.0 // indirect
go.opentelemetry.io/otel/sdk/export/metric v0.28.0 // indirect
go.opentelemetry.io/otel/sdk/metric v0.31.0 // indirect
go.opentelemetry.io/proto/otlp v0.19.0 // indirect
golang.org/x/net v0.0.0-20220909164309-bea034e7d591 // indirect
golang.org/x/sys v0.0.0-20220913175220-63ea55921009 // indirect
golang.org/x/text v0.3.7 // indirect
google.golang.org/genproto v0.0.0-20211129164237-f09f9a12af12 // indirect
google.golang.org/grpc v1.44.0 // indirect
google.golang.org/protobuf v1.27.1 // indirect
google.golang.org/genproto v0.0.0-20220913154956-18f8339a66a5 // indirect
google.golang.org/grpc v1.49.0 // indirect
google.golang.org/protobuf v1.28.1 // indirect
)

replace github.com/aliyun-sls/opentelemetry-go-provider-sls => ../../
31 changes: 17 additions & 14 deletions examples/opentelemetry-sample/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@ import (
"fmt"
"go.opentelemetry.io/otel/attribute"
"go.opentelemetry.io/otel/metric/global"
"go.opentelemetry.io/otel/metric/instrument/asyncfloat64"
"math/rand"
"time"

"github.com/aliyun-sls/opentelemetry-go-provider-sls/provider"

"go.opentelemetry.io/otel"
"go.opentelemetry.io/otel/codes"
"go.opentelemetry.io/otel/metric"
"go.opentelemetry.io/otel/trace"
)

Expand Down Expand Up @@ -57,20 +57,14 @@ func mockMetrics() {
}

meter := global.Meter("ex.com/basic")

c, _ := meter.AsyncFloat64().Counter("randval")

// 观测值,用于定期获取某个计量值,回调函数每个上报周期会被调用一次
_ = metric.Must(meter).NewFloat64CounterObserver(
"randval",
func(_ context.Context, result metric.Float64ObserverResult) {
result.Observe(
rand.Float64(),
labels...,
)
},
metric.WithDescription("A random value"),
)

temperature := metric.Must(meter).NewFloat64Counter("temperature")
interrupts := metric.Must(meter).NewInt64Counter("interrupts")
go mockObserveMetric(c, labels)

temperature, _ := meter.SyncFloat64().Counter("temperature")
interrupts, _ := meter.SyncInt64().Counter("interrupts")

ctx := context.Background()

Expand All @@ -82,6 +76,15 @@ func mockMetrics() {
}
}

func mockObserveMetric(c asyncfloat64.Counter, labels []attribute.KeyValue) {
timer := time.NewTimer(1 * time.Second)
select {
case <-timer.C:
c.Observe(context.Background(), rand.Float64(), labels...)
}
timer.Stop()
}

func mockTrace() {

tracer := otel.Tracer("ex.com/basic")
Expand Down
46 changes: 22 additions & 24 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -3,28 +3,26 @@ module github.com/aliyun-sls/opentelemetry-go-provider-sls
go 1.15

require (
github.com/gorilla/mux v1.8.0
github.com/sethvargo/go-envconfig v0.3.2
github.com/shirou/gopsutil/v3 v3.21.11 // indirect
go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux v0.28.0
go.opentelemetry.io/contrib/instrumentation/host v0.27.0
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.28.0
go.opentelemetry.io/contrib/instrumentation/runtime v0.27.0
go.opentelemetry.io/otel v1.4.0
go.opentelemetry.io/otel/exporters/otlp/otlpmetric v0.27.0
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v0.27.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.4.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.4.0
go.opentelemetry.io/otel/exporters/stdout/stdoutmetric v0.27.0
go.opentelemetry.io/otel/exporters/stdout/stdouttrace v1.4.0
go.opentelemetry.io/otel/metric v0.27.0
go.opentelemetry.io/otel/sdk v1.4.0
go.opentelemetry.io/otel/sdk/export/metric v0.27.0
go.opentelemetry.io/otel/sdk/metric v0.27.0
go.opentelemetry.io/otel/trace v1.4.0
golang.org/x/net v0.0.0-20211201190559-0a0e4e1bb54c // indirect
golang.org/x/sys v0.0.0-20211124211545-fe61309f8881 // indirect
golang.org/x/text v0.3.7 // indirect
google.golang.org/genproto v0.0.0-20211129164237-f09f9a12af12 // indirect
google.golang.org/grpc v1.44.0
github.com/grpc-ecosystem/grpc-gateway/v2 v2.11.3 // indirect
github.com/lufia/plan9stats v0.0.0-20220913051719-115f729f3c8c // indirect
github.com/power-devops/perfstat v0.0.0-20220216144756-c35f1ee13d7c // indirect
github.com/sethvargo/go-envconfig v0.8.2
github.com/tklauser/numcpus v0.5.0 // indirect
go.opentelemetry.io/contrib/instrumentation/host v0.35.0
go.opentelemetry.io/contrib/instrumentation/runtime v0.35.0
go.opentelemetry.io/otel v1.10.0
go.opentelemetry.io/otel/exporters/otlp/otlpmetric v0.31.0
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v0.31.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.10.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.10.0
go.opentelemetry.io/otel/exporters/stdout/stdoutmetric v0.31.0
go.opentelemetry.io/otel/exporters/stdout/stdouttrace v1.10.0
go.opentelemetry.io/otel/metric v0.31.0
go.opentelemetry.io/otel/sdk v1.10.0
go.opentelemetry.io/otel/sdk/export/metric v0.28.0
go.opentelemetry.io/otel/sdk/metric v0.31.0
golang.org/x/net v0.0.0-20220909164309-bea034e7d591 // indirect
golang.org/x/sys v0.0.0-20220913175220-63ea55921009 // indirect
google.golang.org/genproto v0.0.0-20220913154956-18f8339a66a5 // indirect
google.golang.org/grpc v1.49.0
)
Loading

0 comments on commit 999ce03

Please sign in to comment.