change some test path to relative path #170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LYZ seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
kkuai
reviewed
Apr 26, 2019
| @@ -739,7 +739,7 @@ func (s *OssBucketSuite) TestPutObjectNegative(c *C) { | |||
| err = s.bucket.PutObjectFromFile(objectName, "bucket.go", IfModifiedSince(pastDate)) | |||
| c.Assert(err, NotNil) | |||
|
|
|||
| err = s.bucket.PutObjectFromFile(objectName, "/tmp/xxx") | |||
| err = s.bucket.PutObjectFromFile(objectName, "../tmp/xxx") | |||
| c.Assert(err, NotNil) | |||
| } | |||
There was a problem hiding this comment.
目录分隔符需要统一修改为 string(os.PathSeparator),以便做到跨平台兼容。
kkuai
force-pushed
the
master
branch
2 times, most recently
from
07f0838
to
3dce9c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change some test path to relative path