Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve GetNonce method in C#, Swift and php, and add some test code #336

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

h-hg
Copy link
Contributor

@h-hg h-hg commented Jul 31, 2023

Implement GetNonce method like Java, Python or Golang.

@CLAassistant
Copy link

CLAassistant commented Jul 31, 2023

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2023

Codecov Report

Merging #336 (474da48) into master (579e973) will increase coverage by 7.20%.
The diff coverage is n/a.

❗ Current head 474da48 differs from pull request most recent head 76ec737. Consider uploading reports for the commit 76ec737 to get more accurate results

@@             Coverage Diff              @@
##             master     #336      +/-   ##
============================================
+ Coverage     82.07%   89.27%   +7.20%     
+ Complexity      224       98     -126     
============================================
  Files            21       10      -11     
  Lines          2047     1026    -1021     
  Branches         97       46      -51     
============================================
- Hits           1680      916     -764     
+ Misses          350      100     -250     
+ Partials         17       10       -7     
Flag Coverage Δ
csharp ?
golang 95.45% <ø> (ø)
java 67.85% <ø> (ø)
php ?
python 99.39% <ø> (ø)
ts 96.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants