Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement image pasting in md editor #7387

Merged
merged 10 commits into from
Jan 8, 2025
Merged

implement image pasting in md editor #7387

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3a83611
implement image pasting in md editor
reactoholic Jan 3, 2025
619399d
resolve bunny comment
reactoholic Jan 3, 2025
1911a9c
resolve pr comments
reactoholic Jan 6, 2025
3359bb3
resolve bunny comment
reactoholic Jan 6, 2025
237a0de
fix temporaryStorage flag when uploading pasted image
reactoholic Jan 6, 2025
9a26fc7
fix image double pasting issue on initial paste
reactoholic Jan 6, 2025
5c2373c
fix double pasting issue
reactoholic Jan 7, 2025
fb8b8d6
resolve pr comments
reactoholic Jan 8, 2025
0532cf6
Merge branch 'develop' into client-web/7385-implement-image-pasting-i…
bobbykolev Jan 8, 2025
e463c8a
Merge branch 'develop' into client-web/7385-implement-image-pasting-i…
bobbykolev Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/core/ui/forms/MarkdownInput/FormikMarkdownField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,13 +140,13 @@ export const FormikMarkdownField = ({
const clipboardData = event.clipboardData;
const items = clipboardData.items;

if (!items) {
return;
}
if (!items) return;
reactoholic marked this conversation as resolved.
Show resolved Hide resolved

const storageBucketId = storageConfig?.storageBucketId;

if (storageBucketId) {
let hasImage = false;

for (const item of items) {
if (item.type.startsWith('image/')) {
const file = item.getAsFile();
Expand All @@ -165,11 +165,15 @@ export const FormikMarkdownField = ({
});
};

reader.readAsDataURL(file);
event.preventDefault();
reader.readAsDataURL(file); // Read to trigger onLoad.
hasImage = true;
}
}
}

if (hasImage) {
event.preventDefault(); // Prevent default only if there's an image.
}
}
},
[storageConfig?.storageBucketId, uploadFile]
Expand Down