-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: auto-fetching - continuation of #196 #259
Conversation
As a side note, a lot of the dependencies of this package should be updated or dropped like request which is deprecated. Perhaps using rollup as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to get this PR to target the dl
branch?
This way, the feature could be finished before merging this.
Alternatively, I could update the relevant branch on my fork and get you to be a collaborator there so the feature could be implemented without crucial parts missing (cf. comments I left in the code).
Yea ill go through it, ill have to rebase back onto dl. I figured it was a while since it was created so i rebased onto master. Ill revert it back tomorrow. |
It didnt take as long as i thought, its been rebased! @Berkmann18 Its ready when ever you are. |
Following up, any updates on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdalrymple Thanks for the reminder.
A welcomed modernisation with a few errors (see my comments).
Have you tried running this command on an example repo and see if you run into #187 or not?
Thanks for the contributions so far; hopefully, this will hit master
soon 😀.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woo! We're getting there.
Sorry for the missed await!! |
@jdalrymple It's ok. Edit: I've found and re-added the missing model, the only things left are ensuring #187 is fixed and that the feature is at least somewhat usable and this PR is ready to be merged. |
The error you mention i never seem to recreate. Initially the issue looked like it was linked to an improper async file read, but i fixed that :/. Can it be recreated in the dl branch? |
@jdalrymple Yeah, true. |
@jdalrymple I'm not able to fix the conflict which prevents this PR to be merged, could you please have a look? |
@all-contributors Please add @jdalrymple for code |
I've put up a pull request to add @jdalrymple! 🎉 |
Hi is this feature still lined up to make the final cut into a release? |
I resumed work on that, and I've made some improvements and testing changes locally (still work to do but at least it's not on hold). |
* fix: Adjusting file access that was clashing with uncontrolled promises * review: Adding code review changing and linting * fix(cli): rectify an async call Co-authored-by: Maximilian Berkmann <[email protected]>
See #196 for the previous discussion
resolves #187