Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DA-3884] Update retention calculations #3851

Open
wants to merge 5 commits into
base: devel
Choose a base branch
from
Open

[DA-3884] Update retention calculations #3851

wants to merge 5 commits into from

Conversation

pegbertsch
Copy link
Collaborator

@pegbertsch pegbertsch commented Apr 2, 2024

Resolves DA-3884

Description of changes/additions

New NIH guidance on retention calculations: count any PrimaryConsentUpdate response (not just "yes" responses) as an active retention activity, do not credit EHR consent completion for retention eligibility until EHR PDF is successfully validated, and no longer planning to include NPH module 1-3 "no" consents (or opt-ins) as active retention activities.

Corner cases still exist (see DA-3966) for linking a validated EHR PDF to its correct questionnaire_response_id, so the validation check can still be overridden via the retention tool to correct some edge cases if needed. Other cases found were addressed by tweaking the PDR generator for determining the correct questionnaire_response_id to mark SUBMITTED, so PTSC calculations can match RDR's.

Updating the MySQL client to resolve issues running unit tests locally.

Tests

Manual testing of recalculated retention values via the tool (no updates saved to the database) based on known mismatches in production data to confirm PTSC and RDR values will match when the new logic is applied.

@pegbertsch pegbertsch added the on hold merge is on hold, talk to author label Apr 3, 2024
@pegbertsch
Copy link
Collaborator Author

Placing on hold pending outcome of a follow-up meeting with NIH regarding complexities of limiting eligibility to participants with a validated EHR consent PDF (vs. just confirming a "yes" response was received)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do not merge on hold merge is on hold, talk to author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants