[DA-3884] Update retention calculations #3851
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves DA-3884
Description of changes/additions
New NIH guidance on retention calculations: count any PrimaryConsentUpdate response (not just "yes" responses) as an active retention activity, do not credit EHR consent completion for retention eligibility until EHR PDF is successfully validated, and no longer planning to include NPH module 1-3 "no" consents (or opt-ins) as active retention activities.
Corner cases still exist (see DA-3966) for linking a validated EHR PDF to its correct
questionnaire_response_id
, so the validation check can still be overridden via the retention tool to correct some edge cases if needed. Other cases found were addressed by tweaking the PDR generator for determining the correctquestionnaire_response_id
to mark SUBMITTED, so PTSC calculations can match RDR's.Updating the MySQL client to resolve issues running unit tests locally.
Tests
Manual testing of recalculated retention values via the tool (no updates saved to the database) based on known mismatches in production data to confirm PTSC and RDR values will match when the new logic is applied.