Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no ticket][risk=low] renotify when cron job faliures #47

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,12 @@ resource "google_monitoring_alert_policy" "policy" {
}
}
user_labels = lookup(each.value, "userLabels", null)
alert_strategy {
notification_channel_strategy {
renotify_interval = "1d"
}
}

# Don't set notification if input is empty.
notification_channels = var.notification_channel_id == "" ? null : each.value.notificationChannels
}
3 changes: 2 additions & 1 deletion modules/workbench/modules/reporting/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ locals {
# Values that don't ever change set for this dataset.
TABLE_CONSTANTS = {
time_partitioning = null
range_partitioning = null
expiration_time = null
clustering = []
labels = {
Expand Down Expand Up @@ -86,7 +87,7 @@ locals {
# All BigQuery assets for Reporting subsystem
module "main" {
source = "terraform-google-modules/bigquery/google"
version = "~> 4.3"
version = ">= 4.3"
dataset_id = var.reporting_dataset_id
project_id = var.project_id
location = "US"
Expand Down
2 changes: 1 addition & 1 deletion modules/workbench/providers.tf
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Child modules receive their provider configurations from the root module.
terraform {
required_providers {
google = ">= 3.23.0"
google = ">= 4.7.1"
}
}

Expand Down