Ignoring groups when compiling

allegro · Feb 11, 2018 · 02fd222 · 02fd222
1 parent f8b44be
commit 02fd222
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/README.md b/README.md
@@ -253,6 +253,13 @@ IDE Helper and Auto-Complete Support
 
 To integrate this extension with your IDE (PhpStorm, Eclipse etc.) and get auto-complete support, simply include `stubs\ProtobufMessage.php` anywhere under your project root.
 
+Known issues
+------------
+
+* [maps](https://developers.google.com/protocol-buffers/docs/proto#maps) are not fully supported ([#73](https://github.com/allegro/php-protobuf/issues/73))
+* [oneof](https://developers.google.com/protocol-buffers/docs/proto#oneof) is not supported ([#72](https://github.com/allegro/php-protobuf/issues/72))
+* [groups](https://developers.google.com/protocol-buffers/docs/proto#groups) are not supported
+
 References
 ----------
 

diff --git a/src/Allegro/Protobuf/Compiler/PhpGenerator.php b/src/Allegro/Protobuf/Compiler/PhpGenerator.php
@@ -235,6 +235,9 @@ private function _addMessageDescriptor(
                         . 'oneof is not supported (https://github.com/allegro/php-protobuf/issues/72).');
                     $ignoredOneofs[] = $oneofIndex;
                 }
+            } else if ($fieldDescriptorProto->getType()) {
+                $name = $fieldDescriptorProto->getName();
+                Logger::warn("Ignoring '${name}' field, groups are not supported.");
             } else {
                 $fieldDescriptor = new FieldDescriptor();
                 $fieldDescriptor->setName($fieldDescriptorProto->getName());