Don't save vulnerability and security scan history. Fix network ip

address save

src/ralph/api/serializers.py

@@ -192,22 +192,27 @@ class NestedSerializer(RalphAPISerializer):
         return field_class, field_kwargs
 
 
-class ReversionHistoryAPISerializerMixin(object):
+class ReversionHistoryAPISerializerMixin(serializers.ModelSerializer):
+    @property
+    def _save_history(self) -> bool:
+        try:
+            return self.Meta.save_history
+        except AttributeError:
+            return True
 
     def save(self):
-        instance = None
-        with transaction.atomic(), reversion.create_revision():
-            reversion.set_comment('API Save')
-            reversion.set_user(self.context['request'].user)
-            instance = super().save()
-
-        return instance
+        if self._save_history:
+            with transaction.atomic(), reversion.create_revision():
+                reversion.set_comment('API Save')
+                reversion.set_user(self.context['request'].user)
+                return super().save()
+        else:
+            return super().save()
 
 
 class RalphAPISaveSerializer(
     ReversionHistoryAPISerializerMixin,
     TaggitSerializer,
-    serializers.ModelSerializer,
     metaclass=DeclaredFieldsMetaclass
 ):
     serializer_choice_field = ReversedChoiceField

src/ralph/lib/mixins/admin.py

@@ -8,7 +8,7 @@ class MemorizeBeforeStateMixin(object):
 
     def save_model(self, request, obj, form, change):
         if change and obj.pk:
-            obj._before_state = obj._default_manager.get(pk=obj.pk)
+            obj._before_state = obj._meta.default_manager.get(pk=obj.pk)
         super().save_model(request, obj, form, change)
 
 

src/ralph/security/api.py

@@ -17,6 +17,8 @@ class Meta:
         model = Vulnerability
         depth = 1
         fields = "__all__"
+        save_history = False
+
 
 
 class VulnerabilityViewSet(RalphAPIViewSet):
@@ -40,6 +42,7 @@ class SaveSecurityScanSerializer(RalphAPISaveSerializer):
     class Meta:
         model = SecurityScan
         fields = "__all__"
+        save_history = False
 
     def to_internal_value(self, data):
         errors = OrderedDict()

src/ralph/security/models.py

@@ -94,7 +94,7 @@ class SecurityScan(
     vulnerabilities = models.ManyToManyField(Vulnerability, blank=True)
     # this is a quirk field, it is updated manually (for now it's in API)
     # this is because it's hard to handling it automatically
-    # (its value is computated depending on M2M field and M2M signals are
+    # (its value is computed depending on M2M field and M2M signals are
     # complicated)
     is_patched = models.BooleanField(default=False)