Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix affine qnorm config #319

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Fix affine qnorm config #319

merged 1 commit into from
Oct 8, 2023

Conversation

ibeltagy
Copy link
Contributor

@ibeltagy ibeltagy commented Oct 8, 2023

No description provided.

@epwalsh epwalsh changed the base branch from petew/checkpointing to petew/tweaks October 8, 2023 17:42
epwalsh
epwalsh approved these changes Oct 8, 2023
View reviewed changes
Copy link
Member

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you @ibeltagy!

@epwalsh epwalsh changed the base branch from petew/tweaks to petew/checkpointing October 8, 2023 17:43
@epwalsh epwalsh merged commit 5a7d8af into petew/checkpointing Oct 8, 2023
1 check passed
@epwalsh epwalsh deleted the ib/fix_affine_qnorm_config branch October 8, 2023 17:43
@epwalsh
Copy link
Member

epwalsh commented Oct 8, 2023

I applied this to #302 too (933c6ad).

@dirkgr dirkgr restored the ib/fix_affine_qnorm_config branch October 18, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epwalsh epwalsh epwalsh approved these changes

@dirkgr dirkgr Awaiting requested review from dirkgr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibeltagy @epwalsh