Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create S3 client up front #342

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Create S3 client up front #342

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cd02679
Create the global S3 client up front to work around a threading issue…
dirkgr Oct 25, 2023
4a56e49
Productivity through formatting
dirkgr Oct 26, 2023
48bd36f
Any moment now, my productivity will skyrocket
dirkgr Oct 26, 2023
ac7d34a
Merge branch 'main' into S3Client
dirkgr Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion olmo/data/memmap_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from torch.utils.data import Dataset

from ..aliases import PathOrStr
from ..util import file_size, get_bytes_range
from ..util import _get_s3_client, file_size, get_bytes_range

__all__ = ["MemMapDataset"]

Expand Down Expand Up @@ -70,6 +70,9 @@ def max_seq_len(self) -> int:

@property
def offsets(self) -> List[Tuple[int, int]]:
# Create the global S3 client up front to work around a threading issue in boto.
_get_s3_client()

if self._mmap_offsets is None:
import concurrent.futures

Expand Down
Loading