Changes for 65B and 70B runs #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Muennighoff
approved these changes
Feb 7, 2024
olmo/config.py
Outdated
| @@ -243,6 +242,14 @@ class ModelConfig(BaseConfig): | |||
| The number of self-attention heads. | |||
| """ | |||
|
|
|||
| n_kv_heads: Optional[int] = None | |||
| """ | |||
| The number of heads to use for keys and values. | |||
There was a problem hiding this comment.
Suggested change
| The number of heads to use for keys and values. | |
| The number of heads to use for keys and values. Defaults to `n_heads`. |
There was a problem hiding this comment.
Done, I just can't click "commit" here for some reason.
epwalsh
reviewed
Feb 7, 2024
olmo/config.py
Outdated
Comment on lines
456
to
457
| if hasattr(new_config, "optimizer"): | ||
| new_config.optimizer = OptimizerConfig.update_legacy_settings(new_config.optimizer) |
There was a problem hiding this comment.
I am learning that update_leacy_settings doesn't work anyways with settings you specify on the command line.
epwalsh
reviewed
Feb 7, 2024
olmo/config.py
Outdated
| @@ -309,8 +317,7 @@ class ModelConfig(BaseConfig): | |||
|
|
|||
| multi_query_attention: bool = False | |||
There was a problem hiding this comment.
Make this Optional[bool], defaulting to None.
olmo/config.py
Outdated
Comment on lines
439
to
440
| if self.n_kv_heads is None: | ||
| self.n_kv_heads = self.n_heads |
There was a problem hiding this comment.
Then here we could do this:
if self.multi_query_attention:
self.n_kv_heads = 1
elif self.n_kv_heads is None:
self.n_kv_heads = self.n_heads
olmo/config.py
Outdated
| self.n_kv_heads = self.n_heads | ||
|
|
||
| @classmethod | ||
| def update_legacy_settings(cls, config: D) -> D: |
…o mitchish65-2-gqa
Updates to 70B config and checkpointing
GQA into Mitchich65
epwalsh
changed the title
dirkgr
commented
Mar 19, 2024
| # Save metadata. | ||
| self._save_metadata(checkpoint_dir, upload_to=upload_to) | ||
|
|
||
| # Save config. | ||
| self._save_config(checkpoint_dir, upload_to=upload_to) |
There was a problem hiding this comment.
Maybe add a comment explaining why this is now last?
olmo/model.py
Outdated
| @@ -245,7 +260,7 @@ def __init__(self, config: ModelConfig, cache: BufferCache): | |||
| self.config = config | |||
| self.__cache = cache | |||
| # Warm up cache. | |||
| self.get_rotary_embedding(config.max_sequence_length, _non_meta_init_device(config)) | |||
| # self.get_rotary_embedding(config.max_sequence_length, _non_meta_init_device(config)) | |||
There was a problem hiding this comment.
We don't need this anymore?
scripts/beaker/mitchish70.sh
Outdated
| SEED=3423 | ||
| INIT=fan_in | ||
| RUN_NAME="fan-in-init-${SEED}" | ||
| ARGS="--run_name=${RUN_NAME} --data.seed=6198 --seed=${SEED} --model.init_fn=${INIT} --model.init_std=0.006 --model.init_cutoff_factor=3 --device_train_microbatch_size=4 --model.flash_attention=true --fused_loss=true --evaluators=[] --stop_at=500 --wandb.group=mitchish70-ablate-init --save_interval_ephemeral=100" |
There was a problem hiding this comment.
Looks like this isn't the final config anyways.
- Update cluster - Up-sample wikipedia
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.