Work with Python 3.8 #448
Merged
Work with Python 3.8 #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 12, 2024 18:12
|
Hey @hxdtest, this is a good start. Looks like theres maybe a github action issue with 3.8, which I can look at later, and linting is needed for the style check. |
Thanks, I will fix the linting problem. |
|
Yeah this looks good, I'm new to OLMo maintenance, so will see if we can get this merged. |
epwalsh
approved these changes
Feb 13, 2024
sarahwie
pushed a commit
to sarahwie/OLMo
that referenced
this pull request
Feb 16, 2024
Co-authored-by: 玄钛 <[email protected]> Co-authored-by: Pete <[email protected]> Co-authored-by: epwalsh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OLMo doesn't work with Python 3.8. This is because cache is not available before Python 3.9 in functools and MutableMapping from collections.abc doesn't work with Python 3.8 as described issue 446