Rename #466
Merged
Rename #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@epwalsh , @AkshitaB , @2015aroras , how much stuff will break if we merge this? Is it risky? |
|
I agree with you on the version, so I bumped the version number in this PR. |
|
I don't think trainer code or checkpoints will break, so I'm okay with it. Better to make this change now anyway before the next big run. |
2015aroras
reviewed
Mar 8, 2024
CHANGELOG.md
Outdated
| @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| - Added the option to directly pass input embeddings to `OLMo` and `OLMoForCausalLM`. | |||
| - Added support for Python 3.8. | |||
| - Added code to throw an error if `output_attentions` is set to `True` in forward call to `OLMoForCausalLM`. This functionality hasn't been implemented yet. | |||
| - Rename `Olmo` to `OLMo` everywhere in the codebase | |||
There was a problem hiding this comment.
Please move this to Unreleased or v0.3.0 or similar
dirkgr
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #457
As this is a breaking change, it probably makes sense to release a new version with it