Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main blocker was making sure our hacked-together
LocalShardedCheckpointer
class was updated to account for the recent changes to FSDP internals. I've verified that this checkpointer still works correctly. Here is a restart that reproduces the original loss curve perfectly:See https://wandb.ai/ai2-llm/torch-22-testing?workspace=user-epwalsh for full logs.