make garbage collection interval configurable #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2015aroras
approved these changes
Apr 1, 2024
olmo/config.py
Outdated
| @@ -987,6 +987,11 @@ class TrainConfig(BaseConfig): | |||
| How often to log to the console. | |||
| """ | |||
|
|
|||
| gen1_gc_interval: int = 1 | |||
There was a problem hiding this comment.
nit: it might be nice to provide an easy way to turn this off (e.g. setting it to None)
There was a problem hiding this comment.
Done! 989f799
(I assumed you mean disabling manual collection, i.e. not messing with it at all)
dirkgr
approved these changes
Apr 2, 2024
2015aroras
approved these changes
Apr 2, 2024
| @@ -987,9 +987,10 @@ class TrainConfig(BaseConfig): | |||
| How often to log to the console. | |||
| """ | |||
|
|
|||
| gen1_gc_interval: int = 1 | |||
| gen1_gc_interval: Optional[int] = 1 | |||
There was a problem hiding this comment.
Just checking, we want the default behavior to be messing with GC?
There was a problem hiding this comment.
Yes I think so. There might be a better default interval for smaller models, but this was a huge improvement for the 70B.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.