Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ab agent simplified extend joints w fpin #1222

Merged
merged 127 commits into from
Jun 7, 2024
Merged

Ab agent simplified extend joints w fpin #1222

merged 127 commits into from
Jun 7, 2024

Conversation

AlvaroHG
Copy link
Collaborator

@AlvaroHG AlvaroHG commented Jun 7, 2024

  • Rafactors to code
  • Formatting
  • ab agent development, needs validation
  • fpin agent development, needs validation

elimvb and others added 30 commits September 19, 2023 14:08
@elimvb
Fixed tolerance amounts for position and rotation
bf0da1a
@elimvb
Dummy commit (w/ some input commands)
0364ad2
@elimvb
Dummy commit
b823fc7
@AlvaroHG
Merge pull request #1161 from allenai/ab-agent-simplifiedExtendJoints-ah
ce27001 
Dislodgement check
@KuoHaoZeng
add SpawnBoxCollider func
47edb8a
@KuoHaoZeng
precise collider and disable box's renders
d62af6d
@KuoHaoZeng
1. Use emptyGameObject instead of Cube, 2. Spawn two Object, one for …
0be5617 
…triggered and one for nontriggered collider
@KuoHaoZeng
Merge pull request #1194 from allenai/physics-det-new-cam-adjust
ac37993 
merge Physics det new cam adjust to fpin-collider
@KuoHaoZeng
change the way to spawn box collider to UpdateAgentBoxCollider and De…
fa53e86 
…stroyAgentBoxCollider. No initialization or reset anymore
@KuoHaoZeng
add collider size to metadata for return
572f978
@KuoHaoZeng
update imageSynthesis in updateCameraProperties
6e27778
@KuoHaoZeng
remove OnSceneChange
44a43e3
@KuoHaoZeng
add useAbsoluteSize to allow spawn boxCollider by absolute value, ins…
afc72b6 
…tead of scale ratio
@KuoHaoZeng
make SpawnBoxCollider orientation aware
5c82247
@KuoHaoZeng
change according to code review and add extra collistion checks befor…
89a3c88 
…e spawn the collider
@winthos
adding debug draw to visualize Physics.CheckBox...
518fbc1 
also refactoring some redundant calls and adding a new action failed exception that correctly short circuits the actionFinished logic.
@AlvaroHG
Fixes collider box spawning
652b736
@KuoHaoZeng
make collider check aware to size change
d40862d
@winthos
removing old debug visualization...
32f6156 
.. also fixing silent bug where generated colliders via spawnAgentBoxCollider were not tagged on the correct collision layer
@KuoHaoZeng
Merge pull request #1189 from allenai/fpin-collider
0f07e49 
add SpawnBoxCollider func
@winthos
adding prefabs to store agent meshes, adding to asset database
51d3d5d
@winthos
organizing procthor house jsons
3b48487
@winthos
adding initialize/initializebody pipeline to fpin agent
cd2f09d 
-currently copies the mesh from some source spawned prefab onto the agent.

next:
-generate collider based on bounds of mesh
-needs to adjust the center (pivot) of the fps agent controller relative to the generated bounds
-adjust FPSController capsule relative to generated bounds
-.....
@winthos
consolidating generated meshes to single child
11f1630
@winthos
clean up formatting
53f1002
@winthos
generate bounds
3e78de5
@winthos
origin can now be repositioned on initialization
a8d33a2
@winthos
moving spawnAgentBoxCollider logic into fpin agent controller
b4375e6
@winthos
adjusting char controller and trigger capsule after mesh generation
9cabac6
@winthos
fix to third party camera unit tests
1061b82
AlvaroHG and others added 29 commits April 24, 2024 14:46
@AlvaroHG
Option to not sample from navmesh
c7f5434
@winthos
Update FpinAgentController.cs
7994336 
fixing compilation error
@AlvaroHG
Faster shortest path, does not do raycast unless sampleFromNavmesh true
ecb8bee
@AlvaroHG
Removes spurious import
b65ec5c
@AlvaroHG
Merge pull request #1211 from allenai/fpin-agentmode-navmesh
ff97310 
GetShortestPath Improvements
@AlvaroHG
shortest path functions take multiple navMeshIds and find first path …
51ab762 
…on any navmesh
@AlvaroHG
Merge branch 'fpin-agentmode-navmesh' into fpin-agentmode-collidercha…
3e83ea7 
…nges
@elimvb
Giant update to fpin-agent setup
e1fc2da
@elimvb
Accounted for external agent-rotation
6d2572f
@winthos
disable high level agent hand on fpin initialization
150d4d1
@Lucaweihs
Adding in new formatting guidelines / tools.
46c7445
@Lucaweihs
Updating test_thor_msg.py to use objathor and moving things to `scrip…
ad8286b 
…ts`.
@elimvb
Added support for fpin-AbsoluteSize when using a mesh
0ce3118
@AlvaroHG
Trigger build
c62b2ef
@AlvaroHG
Pull and manual megre form main
7c52462
@AlvaroHG
Merge and fixes for Linux build
3e66d43
@AlvaroHG
Trying to make build work
e1ad27b
@AlvaroHG
Removing mac -c flag... if is not working
3b74e99
@AlvaroHG
Fixing some tests
cc1857d
@AlvaroHG
Fixes more unit tests
8bde140
@AlvaroHG
Trigger build
6e2e92f
@AlvaroHG
Merge branch 'fpin-agentmode-colliderchanges-to-main' into ab-agent-s…
6f1aae4 
…implifiedExtendJoints-w-fpin
@AlvaroHG
Compile fix
bd131cb
@AlvaroHG
Testing ab arm benchmarks
65be742
@AlvaroHG
Merge main
60738d9
@AlvaroHG
Merge formatting 2024
e3ed9b4
@AlvaroHG
Format only ai2thor code
fe013f1
@AlvaroHG
Vebosity to format
363be8b
@AlvaroHG
After format
e94dee9
@AlvaroHG AlvaroHG merged commit c87dcc0 into main Jun 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AlvaroHG @elimvb @KuoHaoZeng @winthos @Lucaweihs