Skip to content

Commit

Permalink
allow numbers in exp spec cmd field (#269)
Browse files Browse the repository at this point in the history
  • Loading branch information
epwalsh authored Apr 18, 2024
1 parent 5cc5986 commit 289cae6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ use patch releases for compatibility fixes instead.

## Unreleased

### Fixed

- Numbers are now allowed in `command` and `arguments` fields for experiment specs.

## [v1.26.4](https://github.com/allenai/beaker-py/releases/tag/v1.26.4) - 2024-04-10

### Fixed
Expand Down
4 changes: 2 additions & 2 deletions beaker/data_model/experiment_spec.py
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ class TaskSpec(BaseModel, frozen=False):
It must be unique among all tasks within its experiment.
"""

command: Optional[List[str]] = None
command: Optional[List[Union[str, int, float]]] = None
"""
Command is the full shell command to run as a sequence of separate arguments.
Expand All @@ -358,7 +358,7 @@ class TaskSpec(BaseModel, frozen=False):
Example: ``["python", "-u", "main.py"]``
"""

arguments: Optional[List[str]] = None
arguments: Optional[List[Union[str, int, float]]] = None
"""
Arguments are appended to the command and replace default arguments such as Docker's ``CMD`` directive.
Expand Down

0 comments on commit 289cae6

Please sign in to comment.