Updates beaker-py version to >2. #1021
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishivi
reviewed
Sep 19, 2025
There was a problem hiding this comment.
Hmm running this I get
Traceback (most recent call last):
File "/weka/oe-adapt-default/hamishi/pr_review/open-instruct/mason.py", line 924, in <module>
main()
File "/weka/oe-adapt-default/hamishi/pr_review/open-instruct/mason.py", line 915, in main
tasks=[make_task_spec(args, full_command, i, beaker_secrets, whoami, args.resumable) for i, full_command in enumerate(full_commands)],
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/weka/oe-adapt-default/hamishi/pr_review/open-instruct/mason.py", line 915, in <listcomp>
tasks=[make_task_spec(args, full_command, i, beaker_secrets, whoami, args.resumable) for i, full_command in enumerate(full_commands)],
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/weka/oe-adapt-default/hamishi/pr_review/open-instruct/mason.py", line 852, in make_task_spec
spec = beaker.TaskSpec(
^^^^^^^^^^^^^^^
AttributeError: module 'beaker' has no attribute 'TaskSpec'
|
Oh, that's interesting. Can you share the script? I don't know why my runs
didn't catch that.
…On Fri, Sep 19, 2025 at 14:21, Hamish Ivison ***@***.***> wrote:
***@***.**** commented on this pull request.
Hmm running this I get
Traceback (most recent call last):
File "/weka/oe-adapt-default/hamishi/pr_review/open-instruct/mason.py", line 924, in <module>
main()
File "/weka/oe-adapt-default/hamishi/pr_review/open-instruct/mason.py", line 915, in main
tasks=[make_task_spec(args, full_command, i, beaker_secrets, whoami, args.resumable) for i, full_command in enumerate(full_commands)],
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/weka/oe-adapt-default/hamishi/pr_review/open-instruct/mason.py", line 915, in <listcomp>
tasks=[make_task_spec(args, full_command, i, beaker_secrets, whoami, args.resumable) for i, full_command in enumerate(full_commands)],
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/weka/oe-adapt-default/hamishi/pr_review/open-instruct/mason.py", line 852, in make_task_spec
spec = beaker.TaskSpec(
^^^^^^^^^^^^^^^
AttributeError: module 'beaker' has no attribute 'TaskSpec'
—
Reply to this email directly, view it on GitHub
<#1021 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAYN6ROF7C2FQHRBZNIMYNL3TRQVFAVCNFSM6AAAAACG4OR37KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTENBWHE4TGMRXGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@finbarrtimbers running a slightly edited version of python mason.py --cluster ai2/jupiter-cirrascale-2 --workspace ai2/tulu-3-dev --priority high --image nathanl/open_instruct_auto --pure_docker_mode --preemptible --num_nodes 8 --budget ai2/oe-adapt --gpus 8 -- accelerate launch --mixed_precision bf16 --num_processes 8 --use_deepspeed --deepspeed_config_file configs/ds_configs/stage3_no_offloading_accelerate.conf --deepspeed_multinode_launcher standard open_instruct/finetune.py --exp_name tulu3_8b_sft --model_name_or_path meta-llama/Llama-3.1-8B --model_revision main --tokenizer_name meta-llama/Llama-3.1-8B --tokenizer_revision main --use_slow_tokenizer --dataset_mixer_list allenai/tulu-3-sft-mixture 512 --max_seq_length 4096 --per_device_train_batch_size 1 --gradient_accumulation_steps 2 --learning_rate 5e-06 --lr_scheduler_type linear --warmup_ratio 0.03 --weight_decay 0.0 --num_train_epochs 2 --reduce_loss sum --use_flash_attn --gradient_checkpointing --report_to wandb --with_tracking --logging_steps 1 --seed 8(edited just to reduce the dataset size) |
- Changed beaker_client.workspace.secrets() to beaker_client.secret.list() - Changed beaker_client.account.whoami() to beaker_client.user.get() - Changed beaker.ExperimentSpec to beaker.BeakerExperimentSpec - Changed beaker.Constraints to beaker.BeakerConstraints - Changed beaker.RetrySpec to beaker.BeakerRetrySpec
- Changed all beaker.EnvVar to beaker.BeakerEnvVar - Changed beaker.DataMount to beaker.BeakerDataMount - Changed beaker.DataSource to beaker.BeakerDataSource - Changed beaker.TaskResources to beaker.BeakerTaskResources - Changed beaker.ImageSource to beaker.BeakerImageSource - Changed beaker.ResultSpec to beaker.BeakerResultSpec - Changed beaker.TaskContext to beaker.BeakerTaskContext - Changed beaker.Priority to beaker.BeakerPriority
The experiment.create() method now returns a BeakerWorkload object, which has an experiment field containing the ID.
- Fixed exception names: ConfigurationError → BeakerConfigurationError, ExperimentNotFound → BeakerExperimentNotFound - Updated to use workload.get() and experiment.get_spec() instead of experiment.get() - Changed description update to use workload.update() instead of experiment.set_description() - Updated test mocks to match the new API structure
finbarrtimbers
force-pushed
the
update-beaker-py
branch
from
0d9911f to
cdd2391
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #677.
Experiments: