Skip to content

Fix RepeatPhraseChecker constraints #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −4
Open

Fix RepeatPhraseChecker constraints #1044

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec1f607
Fix RepeatPhraseChecker constraints
nzw0301 Sep 30, 2025
cad4c86
my bad
nzw0301 Sep 30, 2025
7462f93
Remove unnecessary line
nzw0301 Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions open_instruct/IFEvalG/instructions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1543,11 +1543,10 @@ def check_following(self, value):
first_word = self._phrase.split()[0]
last_word = self._phrase.split()[-1]

len(self._phrase.split()) - 2

found_phrases = re.findall(rf"{first_word} .*? {last_word}", value)
if len(found_phrases) != self._small_n:
return False
num_satisfied_phrases = 0
for phrase in found_phrases:
phrase = phrase.split()
ref_phrase = self._phrase.split()
Expand All @@ -1563,8 +1562,9 @@ def check_following(self, value):
return False
except IndexError:
return False
if differences == 1:
return True
num_satisfied_phrases += differences == 1

return num_satisfied_phrases == self._small_n


class CopyChecker(Instruction):
Expand Down