Caches should_stop so we're not hammering Ray.
#973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishivi
approved these changes
Aug 30, 2025
Collaborator
hamishivi
left a comment
hamishivi
left a comment
There was a problem hiding this comment.
Looks good to me, gave it a quick small test. One comment about some logging on a weird case.
| self._should_stop_value = ray.get(ready_refs[0]) | ||
| self._last_should_stop_update = time.perf_counter() | ||
| else: | ||
| ray.cancel(should_stop_ref) |
Collaborator
There was a problem hiding this comment.
Do you think its worth adding some logging here? It seems like if the actor manager doesn't return at all / times out for this call its a sign something is a bit off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #859, I made a number of major changes. To be a better software engineer, I'm breaking them out into separate PRs (and also because there's a bug in #859 that I can't identify).
This caches the value of
should_stopso we're not constantly hammering Ray.Single GPU run: Beaker.